romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-14 21:31:42 +03:00
Code Issues Projects Releases Packages Wiki Activity

clang-tidy: enable more checks, fix fallouts

Browse source 
- enable three checks:
  - bugprone-invalid-enum-default-initialization
  - bugprone-sizeof-expression
  - readability-inconsistent-declaration-parameter-name (strict)
- fix remaining discrepancies with arg names in prototypes
  and implementation, in strict mode.
- document reason for some checks tested but not enabled.

Closes #20794
This commit is contained in:
Viktor Szakats 2026-03-03 01:58:29 +01:00
parent e0dd6eb4a4
commit df6014894b
No known key found for this signature in database
34 changed files with 222 additions and 209 deletions
Download patch file Download diff file Expand all files Collapse all files

22
lib/multi.c
View file

@ -453,11 +453,11 @@ static CURLMcode multi_xfers_add(struct Curl_multi *multi,
return CURLM_OK;
}
CURLMcode curl_multi_add_handle(CURLM *m, CURL *d)
CURLMcode curl_multi_add_handle(CURLM *m, CURL *curl)
{
CURLMcode mresult;
struct Curl_multi *multi = m;
struct Curl_easy *data = d;
struct Curl_easy *data = curl;
/* First, make some basic checks that the CURLM handle is a good handle */
if(!GOOD_MULTI_HANDLE(multi))
@ -775,10 +775,10 @@ static void close_connect_only(struct connectdata *conn,
connclose(conn, "Removing connect-only easy handle");
}
CURLMcode curl_multi_remove_handle(CURLM *m, CURL *d)
CURLMcode curl_multi_remove_handle(CURLM *m, CURL *curl)
{
struct Curl_multi *multi = m;
struct Curl_easy *data = d;
struct Curl_easy *data = curl;
bool premature;
struct Curl_llist_node *e;
CURLMcode mresult;
@ -1655,22 +1655,22 @@ out:
return mresult;
}
CURLMcode curl_multi_wait(CURLM *multi,
CURLMcode curl_multi_wait(CURLM *m,
struct curl_waitfd extra_fds[],
unsigned int extra_nfds,
int timeout_ms,
int *ret)
{
return multi_wait(multi, extra_fds, extra_nfds, timeout_ms, ret, FALSE);
return multi_wait(m, extra_fds, extra_nfds, timeout_ms, ret, FALSE);
}
CURLMcode curl_multi_poll(CURLM *multi,
CURLMcode curl_multi_poll(CURLM *m,
struct curl_waitfd extra_fds[],
unsigned int extra_nfds,
int timeout_ms,
int *ret)
{
return multi_wait(multi, extra_fds, extra_nfds, timeout_ms, ret, TRUE);
return multi_wait(m, extra_fds, extra_nfds, timeout_ms, ret, TRUE);
}
CURLMcode curl_multi_wakeup(CURLM *m)
@ -3723,14 +3723,14 @@ void Curl_expire_clear(struct Curl_easy *data)
}
}
CURLMcode curl_multi_assign(CURLM *m, curl_socket_t s,
void *hashp)
CURLMcode curl_multi_assign(CURLM *m, curl_socket_t sockfd,
void *sockp)
{
struct Curl_multi *multi = m;
if(!GOOD_MULTI_HANDLE(multi))
return CURLM_BAD_HANDLE;
return Curl_multi_ev_assign(multi, s, hashp);
return Curl_multi_ev_assign(multi, sockfd, sockp);
}
static void move_pending_to_connect(struct Curl_multi *multi,