romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-24 12:27:16 +03:00
Code Issues Projects Releases Packages Wiki Activity

clang-tidy: enable more checks, fix fallouts

Browse source 
- enable three checks:
  - bugprone-invalid-enum-default-initialization
  - bugprone-sizeof-expression
  - readability-inconsistent-declaration-parameter-name (strict)
- fix remaining discrepancies with arg names in prototypes
  and implementation, in strict mode.
- document reason for some checks tested but not enabled.

Closes #20794
This commit is contained in:
Viktor Szakats 2026-03-03 01:58:29 +01:00
parent e0dd6eb4a4
commit df6014894b
No known key found for this signature in database
34 changed files with 222 additions and 209 deletions
Download patch file Download diff file Expand all files Collapse all files

24
lib/headers.c
View file

@ -52,23 +52,23 @@ static void copy_header_external(struct Curl_header_store *hs,
}
/* public API */
CURLHcode curl_easy_header(CURL *easy,
CURLHcode curl_easy_header(CURL *curl,
const char *name,
size_t nameindex,
unsigned int type,
unsigned int origin,
int request,
struct curl_header **hout)
{
struct Curl_llist_node *e;
struct Curl_llist_node *e_pick = NULL;
struct Curl_easy *data = easy;
struct Curl_easy *data = curl;
size_t match = 0;
size_t amount = 0;
struct Curl_header_store *hs = NULL;
struct Curl_header_store *pick = NULL;
if(!name || !hout || !data ||
(type > (CURLH_HEADER | CURLH_TRAILER | CURLH_CONNECT | CURLH_1XX |
CURLH_PSEUDO)) || !type || (request < -1))
(origin > (CURLH_HEADER | CURLH_TRAILER | CURLH_CONNECT | CURLH_1XX |
CURLH_PSEUDO)) || !origin || (request < -1))
return CURLHE_BAD_ARGUMENT;
if(!Curl_llist_count(&data->state.httphdrs))
return CURLHE_NOHEADERS; /* no headers available */
@ -81,7 +81,7 @@ CURLHcode curl_easy_header(CURL *easy,
for(e = Curl_llist_head(&data->state.httphdrs); e; e = Curl_node_next(e)) {
hs = Curl_node_elem(e);
if(curl_strequal(hs->name, name) &&
(hs->type & type) &&
(hs->type & origin) &&
(hs->request == request)) {
amount++;
pick = hs;
@ -100,7 +100,7 @@ CURLHcode curl_easy_header(CURL *easy,
for(e = Curl_llist_head(&data->state.httphdrs); e; e = Curl_node_next(e)) {
hs = Curl_node_elem(e);
if(curl_strequal(hs->name, name) &&
(hs->type & type) &&
(hs->type & origin) &&
(hs->request == request) &&
(match++ == nameindex)) {
e_pick = e;
@ -118,12 +118,12 @@ CURLHcode curl_easy_header(CURL *easy,
}
/* public API */
struct curl_header *curl_easy_nextheader(CURL *easy,
unsigned int type,
struct curl_header *curl_easy_nextheader(CURL *curl,
unsigned int origin,
int request,
struct curl_header *prev)
{
struct Curl_easy *data = easy;
struct Curl_easy *data = curl;
struct Curl_llist_node *pick;
struct Curl_llist_node *e;
struct Curl_header_store *hs;
@ -149,7 +149,7 @@ struct curl_header *curl_easy_nextheader(CURL *easy,
/* make sure it is the next header of the desired type */
do {
hs = Curl_node_elem(pick);
if((hs->type & type) && (hs->request == request))
if((hs->type & origin) && (hs->request == request))
break;
pick = Curl_node_next(pick);
} while(pick);
@ -167,7 +167,7 @@ struct curl_header *curl_easy_nextheader(CURL *easy,
struct Curl_header_store *check = Curl_node_elem(e);
if(curl_strequal(hs->name, check->name) &&
(check->request == request) &&
(check->type & type))
(check->type & origin))
amount++;
if(e == pick)
index = amount - 1;