romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-31 07:38:04 +03:00
Code Issues Projects Releases Packages Wiki Activity

curl: cap the maximum allowed values for retry time arguments

Browse source 
... to avoid integer overflows later when multiplying with 1000 to
convert seconds to milliseconds.

Added test 1269 to verify.

Reported-by: Jason Lee
Closes #4166
This commit is contained in:
Daniel Stenberg 2019-07-29 22:10:13 +02:00
parent d23e87d551
commit db0a0dfb0e
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
5 changed files with 61 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/data/Makefile.inc
View file

@ -140,7 +140,7 @@ test1236 test1237 test1238 test1239 test1240 test1241 test1242 test1243 \
test1244 test1245 test1246 test1247 test1248 test1249 test1250 test1251 \
test1252 test1253 test1254 test1255 test1256 test1257 test1258 test1259 \
test1260 test1261 test1262 test1263 test1264 test1265 test1266 test1267 \
test1268 \
test1268 test1269 \
\
test1280 test1281 test1282 test1283 test1284 test1285 test1286 test1287 \
test1288 test1289 test1290 test1291 test1292 \

34
tests/data/test1269 Normal file
View file

@ -0,0 +1,34 @@
<testcase>
<info>
<keywords>
--retry-delay
</keywords>
</info>
#
# Server-side
<reply>
</reply>
#
# Client-side
<client>
<server>
none
</server>
<name>
too large --retry-delay value
</name>
<command>
--retry 3 --retry-delay 9223372036854776 http://%HOSTIP:%HTTPPORT/1269
</command>
</client>
#
# Verify data after the test has been "shot"
<verify>
<errorcode>
2
</errorcode>
</verify>
</testcase>