mirror of
https://github.com/curl/curl.git
synced 2026-08-25 07:43:32 +03:00
checksrc: fix SPACEBEFOREPAREN for conditions starting with "*"
The open paren check wants to warn for spaces before open parenthesis for if/while/for but also for any function call. In order to avoid catching function pointer declarations, the logic allows a space if the first character after the open parenthesis is an asterisk. I also spotted what we did not include "switch" in the check but we should. This check is a little lame, but we reduce this problem by not allowing that space for if/while/for/switch. Reported-by: Emanuele Torre Closes #11044
This commit is contained in:
parent
4578ada4a0
commit
d567cca1de
14 changed files with 22 additions and 20 deletions
|
|
@ -369,7 +369,7 @@ ParameterError proto2num(struct OperationConfig *config,
|
|||
|
||||
/* Process token modifiers */
|
||||
while(!ISALNUM(*token)) { /* may be NULL if token is all modifiers */
|
||||
switch (*token++) {
|
||||
switch(*token++) {
|
||||
case '=':
|
||||
action = set;
|
||||
break;
|
||||
|
|
|
|||
|
|
@ -100,7 +100,7 @@ static CURLcode glob_set(struct URLGlob *glob, char **patternp,
|
|||
pat->globindex = globindex;
|
||||
|
||||
while(!done) {
|
||||
switch (*pattern) {
|
||||
switch(*pattern) {
|
||||
case '\0': /* URL ended while set was still open */
|
||||
return GLOBERROR("unmatched brace", opos, CURLE_URL_MALFORMAT);
|
||||
|
||||
|
|
@ -411,7 +411,7 @@ static CURLcode glob_parse(struct URLGlob *glob, char *pattern,
|
|||
res = glob_fixed(glob, glob->glob_buffer, sublen);
|
||||
}
|
||||
else {
|
||||
switch (*pattern) {
|
||||
switch(*pattern) {
|
||||
case '\0': /* done */
|
||||
break;
|
||||
|
||||
|
|
|
|||
|
|
@ -61,7 +61,7 @@ void jsonWriteString(FILE *stream, const char *in, bool lowercase)
|
|||
fputs("\\t", stream);
|
||||
break;
|
||||
default:
|
||||
if (*i < 32) {
|
||||
if(*i < 32) {
|
||||
fprintf(stream, "u%04x", *i);
|
||||
}
|
||||
else {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue