checksrc: fix SPACEBEFOREPAREN for conditions starting with "*"

The open paren check wants to warn for spaces before open parenthesis
for if/while/for but also for any function call. In order to avoid
catching function pointer declarations, the logic allows a space if the
first character after the open parenthesis is an asterisk.

I also spotted what we did not include "switch" in the check but we should.

This check is a little lame, but we reduce this problem by not allowing
that space for if/while/for/switch.

Reported-by: Emanuele Torre
Closes #11044
This commit is contained in:
Daniel Stenberg 2023-04-27 16:29:45 +02:00
parent 4578ada4a0
commit d567cca1de
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
14 changed files with 22 additions and 20 deletions

View file

@ -678,7 +678,7 @@ static int ipv4_normalize(struct dynbuf *host)
parts[n] = l;
c = endp;
switch (*c) {
switch(*c) {
case '.' :
if(n == 3)
return HOST_BAD;