From d0ad652552564cbcf5c2f14869db0add4ff4ac50 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Tue, 25 Nov 2025 09:09:50 +0100 Subject: [PATCH] progress: remove two redundant variable checks The entry condition in the function already exits early if either low_speed_time or low_speed_limit is not set. Pointed out by CodeSonar Closes #19686 --- lib/progress.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/progress.c b/lib/progress.c index 3985e1c1bf..59c5b9a00f 100644 --- a/lib/progress.c +++ b/lib/progress.c @@ -109,7 +109,7 @@ UNITTEST CURLcode pgrs_speedcheck(struct Curl_easy *data, /* A paused transfer is not qualified for speed checks */ return CURLE_OK; - if((data->progress.current_speed >= 0) && data->set.low_speed_time) { + if(data->progress.current_speed >= 0) { if(data->progress.current_speed < data->set.low_speed_limit) { if(!data->state.keeps_speed.tv_sec) /* under the limit at this moment */ @@ -134,10 +134,9 @@ UNITTEST CURLcode pgrs_speedcheck(struct Curl_easy *data, data->state.keeps_speed.tv_sec = 0; } - if(data->set.low_speed_limit) - /* if low speed limit is enabled, set the expire timer to make this - connection's speed get checked again in a second */ - Curl_expire(data, 1000, EXPIRE_SPEEDCHECK); + /* since low speed limit is enabled, set the expire timer to make this + connection's speed get checked again in a second */ + Curl_expire(data, 1000, EXPIRE_SPEEDCHECK); return CURLE_OK; }