tests: constify command-line arguments

For libtests, tunits, units.

Also:
- lib3033: tidy up headers.
- lib/netrc: constify an arg in `Curl_parsenetrc()`.

Closes #18076

tests/unit/README.md

@@ -49,7 +49,7 @@ For the actual C file, here's a simple example:
 
     #include "a libcurl header.h" /* from the lib dir */
 
-    static CURLcode test_unit9998(char *arg)
+    static CURLcode test_unit9998(const char *arg)
     {
       UNITTEST_BEGIN_SIMPLE
 
@@ -81,7 +81,7 @@ Here's an example using optional initialization and cleanup:
       /* done before shutting down and exiting */
     }
 
-    static CURLcode test_unit9999(char *arg)
+    static CURLcode test_unit9999(const char *arg)
     {
       UNITTEST_BEGIN(t9999_setup())
 

tests/unit/unit1300.c

@@ -33,7 +33,7 @@ static void test_Curl_llist_dtor(void *key, void *value)
   (void)value;
 }
 
-static CURLcode test_unit1300(char *arg)
+static CURLcode test_unit1300(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1302.c

@@ -34,7 +34,7 @@ struct etest {
   size_t olen;
 };
 
-static CURLcode test_unit1302(char *arg)
+static CURLcode test_unit1302(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
   CURLcode rc;

tests/unit/unit1303.c

@@ -65,7 +65,7 @@ static void t1303_stop(struct Curl_easy *easy)
  * N           various values of now
  */
 
-static CURLcode test_unit1303(char *arg)
+static CURLcode test_unit1303(const char *arg)
 {
   struct Curl_easy *easy;
 

tests/unit/unit1304.c

@@ -33,7 +33,7 @@ static void t1304_stop(char **password, char **login)
   Curl_safefree(*login);
 }
 
-static CURLcode test_unit1304(char *arg)
+static CURLcode test_unit1304(const char *arg)
 {
   char *login = NULL;
   char *password = NULL;
@@ -178,7 +178,7 @@ static CURLcode test_unit1304(char *arg)
 
 #else
 
-static CURLcode test_unit1304(char *arg)
+static CURLcode test_unit1304(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
   UNITTEST_END_SIMPLE

tests/unit/unit1305.c

@@ -97,7 +97,7 @@ static CURLcode create_node(void)
   return CURLE_OK;
 }
 
-static CURLcode test_unit1305(char *arg)
+static CURLcode test_unit1305(const char *arg)
 {
   UNITTEST_BEGIN(t1305_setup())
 

tests/unit/unit1307.c

@@ -63,7 +63,7 @@ static const char *ret2name(int i)
   /* not reached */
 }
 
-static CURLcode test_unit1307(char *arg)
+static CURLcode test_unit1307(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 
@@ -311,7 +311,7 @@ static CURLcode test_unit1307(char *arg)
 
 #else
 
-static CURLcode test_unit1307(char *arg)
+static CURLcode test_unit1307(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
   UNITTEST_END_SIMPLE

tests/unit/unit1309.c

@@ -56,7 +56,7 @@ static void splayprint(struct Curl_tree *t, int d, char output)
   splayprint(t->smaller, d + 1, output);
 }
 
-static CURLcode test_unit1309(char *arg)
+static CURLcode test_unit1309(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1323.c

@@ -23,7 +23,7 @@
  ***************************************************************************/
 #include "unitcheck.h"
 
-static CURLcode test_unit1323(char *arg)
+static CURLcode test_unit1323(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1330.c

@@ -25,7 +25,7 @@
 
 #include "memdebug.h"
 
-static CURLcode test_unit1330(char *arg)
+static CURLcode test_unit1330(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1395.c

@@ -25,7 +25,7 @@
 #include "memdebug.h"
 #include "unitprotos.h"
 
-static CURLcode test_unit1395(char *arg)
+static CURLcode test_unit1395(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1396.c

@@ -37,7 +37,7 @@ static void t1396_stop(CURL *easy)
   curl_global_cleanup();
 }
 
-static CURLcode test_unit1396(char *arg)
+static CURLcode test_unit1396(const char *arg)
 {
   CURL *easy;
 

tests/unit/unit1397.c

@@ -25,7 +25,7 @@
 
 #include "vtls/hostcheck.h"
 
-static CURLcode test_unit1397(char *arg)
+static CURLcode test_unit1397(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1398.c

@@ -28,7 +28,7 @@
 #pragma GCC diagnostic ignored "-Wformat"
 #endif
 
-static CURLcode test_unit1398(char *arg)
+static CURLcode test_unit1398(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1399.c

@@ -71,7 +71,7 @@ static void expect_timer_seconds(struct Curl_easy *data, int seconds)
  * E.g., if t_starttransfer took 2 seconds initially and took another 1
  * second for the redirect request, then the resulting t_starttransfer should
  * be 3 seconds. */
-static CURLcode test_unit1399(char *arg)
+static CURLcode test_unit1399(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1600.c

@@ -45,7 +45,7 @@ static void t1600_stop(CURL *easy)
   curl_global_cleanup();
 }
 
-static CURLcode test_unit1600(char *arg)
+static CURLcode test_unit1600(const char *arg)
 {
   CURL *easy;
 

tests/unit/unit1601.c

@@ -25,7 +25,7 @@
 
 #include "curl_md5.h"
 
-static CURLcode test_unit1601(char *arg)
+static CURLcode test_unit1601(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1602.c

@@ -45,7 +45,7 @@ static void t1602_stop(struct Curl_hash *hash)
   Curl_hash_destroy(hash);
 }
 
-static CURLcode test_unit1602(char *arg)
+static CURLcode test_unit1602(const char *arg)
 {
   struct Curl_hash hash;
 

tests/unit/unit1603.c

@@ -57,7 +57,7 @@ static void t1603_stop(struct Curl_hash *hash_static)
   Curl_hash_destroy(hash_static);
 }
 
-static CURLcode test_unit1603(char *arg)
+static CURLcode test_unit1603(const char *arg)
 {
   struct Curl_hash hash_static;
 

tests/unit/unit1605.c

@@ -44,7 +44,7 @@ static void t1605_stop(CURL *easy)
   curl_global_cleanup();
 }
 
-static CURLcode test_unit1605(char *arg)
+static CURLcode test_unit1605(const char *arg)
 {
   CURL *easy;
 

tests/unit/unit1606.c

@@ -76,7 +76,7 @@ static int runawhile(struct Curl_easy *easy,
   return finaltime;
 }
 
-static CURLcode test_unit1606(char *arg)
+static CURLcode test_unit1606(const char *arg)
 {
   struct Curl_easy *easy;
 

tests/unit/unit1607.c

@@ -36,7 +36,7 @@ static CURLcode t1607_setup(void)
   return res;
 }
 
-static CURLcode test_unit1607(char *arg)
+static CURLcode test_unit1607(const char *arg)
 {
   /* In builds without IPv6 support CURLOPT_RESOLVE should skip over those
      addresses, so we have to do that as well. */

tests/unit/unit1608.c

@@ -42,7 +42,7 @@ static CURLcode t1608_setup(void)
   return CURLE_OK;
 }
 
-static CURLcode test_unit1608(char *arg)
+static CURLcode test_unit1608(const char *arg)
 {
   UNITTEST_BEGIN(t1608_setup())
 
@@ -74,7 +74,7 @@ static CURLcode test_unit1608(char *arg)
 
 #else
 
-static CURLcode test_unit1608(char *arg)
+static CURLcode test_unit1608(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
   UNITTEST_END_SIMPLE

tests/unit/unit1609.c

@@ -68,7 +68,7 @@ Test:
  expected result: cached address has zero timestamp and new address
 */
 
-static CURLcode test_unit1609(char *arg)
+static CURLcode test_unit1609(const char *arg)
 {
   UNITTEST_BEGIN(t1609_setup())
 

tests/unit/unit1610.c

@@ -32,7 +32,7 @@ static CURLcode t1610_setup(void)
   return res;
 }
 
-static CURLcode test_unit1610(char *arg)
+static CURLcode test_unit1610(const char *arg)
 {
   UNITTEST_BEGIN(t1610_setup())
 

tests/unit/unit1611.c

@@ -25,7 +25,7 @@
 
 #include "curl_md4.h"
 
-static CURLcode test_unit1611(char *arg)
+static CURLcode test_unit1611(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1612.c

@@ -26,7 +26,7 @@
 #include "curl_hmac.h"
 #include "curl_md5.h"
 
-static CURLcode test_unit1612(char *arg)
+static CURLcode test_unit1612(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1614.c

@@ -25,7 +25,7 @@
 
 #include "noproxy.h"
 
-static CURLcode test_unit1614(char *arg)
+static CURLcode test_unit1614(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1615.c

@@ -26,7 +26,7 @@
 
 #include "curl_sha512_256.h"
 
-static CURLcode test_unit1615(char *arg)
+static CURLcode test_unit1615(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1616.c

@@ -45,7 +45,7 @@ static void t1616_stop(struct uint_hash *hash)
   Curl_uint_hash_destroy(hash);
 }
 
-static CURLcode test_unit1616(char *arg)
+static CURLcode test_unit1616(const char *arg)
 {
   struct uint_hash hash;
 

tests/unit/unit1620.c

@@ -69,7 +69,7 @@ static void t1620_parse(
   free(options);
 }
 
-static CURLcode test_unit1620(char *arg)
+static CURLcode test_unit1620(const char *arg)
 {
   UNITTEST_BEGIN(t1620_setup())
 

tests/unit/unit1650.c

@@ -25,7 +25,7 @@
 
 #include "doh.h"
 
-static CURLcode test_unit1650(char *arg)
+static CURLcode test_unit1650(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1651.c

@@ -25,7 +25,7 @@
 
 #include "vtls/x509asn1.h"
 
-static CURLcode test_unit1651(char *arg)
+static CURLcode test_unit1651(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1652.c

@@ -82,7 +82,7 @@ static int verify(const char *info, const char *two)
   return strncmp(info, two, nl - info);
 }
 
-static CURLcode test_unit1652(char *arg)
+static CURLcode test_unit1652(const char *arg)
 {
   struct Curl_easy *easy;
 

tests/unit/unit1653.c

@@ -41,7 +41,7 @@ static CURLUcode parse_port(CURLU *url, char *h, bool has_scheme)
   return ret;
 }
 
-static CURLcode test_unit1653(char *arg)
+static CURLcode test_unit1653(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1654.c

@@ -26,7 +26,7 @@
 #include "urldata.h"
 #include "altsvc.h"
 
-static CURLcode test_unit1654(char *arg)
+static CURLcode test_unit1654(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1655.c

@@ -25,7 +25,7 @@
 
 #include "doh.h" /* from the lib dir */
 
-static CURLcode test_unit1655(char *arg)
+static CURLcode test_unit1655(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1656.c

@@ -56,7 +56,7 @@ static bool do_test(const struct test_spec *spec, size_t i,
   return TRUE;
 }
 
-static CURLcode test_unit1656(char *arg)
+static CURLcode test_unit1656(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 
@@ -114,7 +114,7 @@ static CURLcode test_unit1656(char *arg)
 
 #else
 
-static CURLcode test_unit1656(char *arg)
+static CURLcode test_unit1656(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
   puts("not tested since Curl_x509_GTime2str() is not built in");

tests/unit/unit1657.c

@@ -85,7 +85,7 @@ static bool do_test1657(const struct test1657_spec *spec, size_t i,
   return TRUE;
 }
 
-static CURLcode test_unit1657(char *arg)
+static CURLcode test_unit1657(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 
@@ -114,7 +114,7 @@ static CURLcode test_unit1657(char *arg)
 
 #else
 
-static CURLcode test_unit1657(char *arg)
+static CURLcode test_unit1657(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
   puts("not tested since Curl_x509_getASN1Element() is not built in");

tests/unit/unit1658.c

@@ -114,7 +114,7 @@ static void rrresults(struct Curl_https_rrinfo *rr, CURLcode result)
   }
 }
 
-static CURLcode test_unit1658(char *arg)
+static CURLcode test_unit1658(const char *arg)
 {
   UNITTEST_BEGIN(t1658_setup())
 
@@ -543,7 +543,7 @@ static CURLcode test_unit1658(char *arg)
 
 #else /* CURL_DISABLE_DOH or not HTTPSRR enabled */
 
-static CURLcode test_unit1658(char *arg)
+static CURLcode test_unit1658(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
   UNITTEST_END_SIMPLE

tests/unit/unit1660.c

@@ -27,7 +27,7 @@
 #include "hsts.h"
 
 #if defined(CURL_DISABLE_HTTP) || defined(CURL_DISABLE_HSTS)
-static CURLcode test_unit1660(char *arg)
+static CURLcode test_unit1660(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
   puts("nothing to do when HTTP or HSTS are disabled");
@@ -46,7 +46,7 @@ static void showsts(struct stsentry *e, const char *chost)
   }
 }
 
-static CURLcode test_unit1660(char *arg)
+static CURLcode test_unit1660(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1661.c

@@ -45,7 +45,7 @@ static void t1661_stop(struct bufref *bufref)
   Curl_bufref_free(bufref);
 }
 
-static CURLcode test_unit1661(char *arg)
+static CURLcode test_unit1661(const char *arg)
 {
   struct bufref bufref;
 

tests/unit/unit1663.c

@@ -72,7 +72,7 @@ static void t1663_parse(
   free(host);
 }
 
-static CURLcode test_unit1663(char *arg)
+static CURLcode test_unit1663(const char *arg)
 {
   UNITTEST_BEGIN(t1663_setup())
 

tests/unit/unit1664.c

@@ -39,7 +39,7 @@ static CURLcode t1664_setup(void)
   return res;
 }
 
-static CURLcode test_unit1664(char *arg)
+static CURLcode test_unit1664(const char *arg)
 {
   UNITTEST_BEGIN(t1664_setup())
 

tests/unit/unit1979.c

@@ -25,7 +25,7 @@
 
 #include "http_aws_sigv4.h"
 
-static CURLcode test_unit1979(char *arg)
+static CURLcode test_unit1979(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit1980.c

@@ -25,7 +25,7 @@
 
 #include "http_aws_sigv4.h"
 
-static CURLcode test_unit1980(char *arg)
+static CURLcode test_unit1980(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit2600.c

@@ -352,7 +352,7 @@ static void test_connect(CURL *easy, const struct test_case *tc)
 #define TC_TMOT     90000  /* 90 sec max test duration */
 #define CNCT_TMOT   60000  /* 60sec connect timeout */
 
-static CURLcode test_unit2600(char *arg)
+static CURLcode test_unit2600(const char *arg)
 {
   CURL *easy;
 

tests/unit/unit2601.c

@@ -205,7 +205,7 @@ static void check_bufq(size_t pool_spares,
     Curl_bufcp_free(&pool);
 }
 
-static CURLcode test_unit2601(char *arg)
+static CURLcode test_unit2601(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit2602.c

@@ -27,7 +27,7 @@
 #include "dynhds.h"
 #include "curl_trc.h"
 
-static CURLcode test_unit2602(char *arg)
+static CURLcode test_unit2602(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit2603.c

@@ -112,7 +112,7 @@ static void parse_success(const struct tcase *t)
 }
 #endif
 
-static CURLcode test_unit2603(char *arg)
+static CURLcode test_unit2603(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit2604.c

@@ -25,7 +25,7 @@
 #include "vssh/curl_path.h"
 #include "memdebug.h"
 
-static CURLcode test_unit2604(char *arg)
+static CURLcode test_unit2604(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit3200.c

@@ -25,7 +25,7 @@
 #include "curl_get_line.h"
 #include "memdebug.h"
 
-static CURLcode test_unit3200(char *arg)
+static CURLcode test_unit3200(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit3205.c

@@ -25,7 +25,7 @@
 
 #include "vtls/cipher_suite.h"
 
-static CURLcode test_unit3205(char *arg)
+static CURLcode test_unit3205(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit3211.c

@@ -120,7 +120,7 @@ static void check_set(const char *name, unsigned int capacity,
   Curl_uint_bset_destroy(&bset);
 }
 
-static CURLcode test_unit3211(char *arg)
+static CURLcode test_unit3211(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit3212.c

@@ -41,7 +41,7 @@ static void t3212_stop(struct uint_tbl *tbl)
   Curl_uint_tbl_destroy(tbl);
 }
 
-static CURLcode test_unit3212(char *arg)
+static CURLcode test_unit3212(const char *arg)
 {
   struct uint_tbl tbl;
   int dummy;

tests/unit/unit3213.c

@@ -90,7 +90,7 @@ static void check_spbset(const char *name, const unsigned int *s, size_t slen)
   Curl_uint_spbset_destroy(&bset);
 }
 
-static CURLcode test_unit3213(char *arg)
+static CURLcode test_unit3213(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE
 

tests/unit/unit3214.c

@@ -56,7 +56,7 @@ static void checksize(const char *name, size_t size, size_t allowed)
 #define MAX_CURLMSG             24
 #define MAX_CURL_HEADER         48
 
-static CURLcode test_unit3214(char *arg)
+static CURLcode test_unit3214(const char *arg)
 {
   UNITTEST_BEGIN_SIMPLE