From cb4b3e75e808c6527e85d31a64a8ded421d85279 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Tue, 9 Jun 2026 12:58:24 +0200 Subject: [PATCH] smbserver: check impacket presence differently To silence ruff and GitHub CodeQL warnings. Closes #21929 --- tests/smbserver.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/smbserver.py b/tests/smbserver.py index 9b38c4695a..c3eeb1105c 100755 --- a/tests/smbserver.py +++ b/tests/smbserver.py @@ -25,6 +25,7 @@ import argparse import configparser +import importlib.util import logging import os import signal @@ -36,9 +37,7 @@ import threading from util import ClosingFileHandler, TestData # impacket needs to be installed in the Python environment -try: - import impacket # noqa: F401 -except ImportError: +if importlib.util.find_spec('impacket') is None: sys.stderr.write( 'Warning: Python package impacket is required for smb testing; ' 'use pip or your package manager to install it\n')