mirror of
https://github.com/curl/curl.git
synced 2026-08-26 14:33:32 +03:00
pytest: close file handles after use (cont.), and tidy-ups
- dante.py, dnsd.py, sshd.py: drop redundant conditions.
Spotted in sshd by GitHub Code Quality.
- curl.py: comment out `if` to silence CodeQL warning.
Reported by GitHub CodeQL
Follow-up to 8145476d5d #21916
Closes #21917
This commit is contained in:
parent
7b9d74abf6
commit
cb4465bfe6
9 changed files with 91 additions and 35 deletions
|
|
@ -56,6 +56,7 @@ class Dnsd:
|
|||
self._conf_file = os.path.join(self._log_dir, 'dnsd.cmd')
|
||||
self._pid_file = os.path.join(self._log_dir, 'dnsd.pid')
|
||||
self._error_log = os.path.join(self._log_dir, 'dnsd.err.log')
|
||||
self._error_fd = None
|
||||
self._process = None
|
||||
|
||||
self.clear_logs()
|
||||
|
|
@ -64,6 +65,11 @@ class Dnsd:
|
|||
def port(self) -> int:
|
||||
return self._port
|
||||
|
||||
def close_log(self):
|
||||
if self._error_fd:
|
||||
self._error_fd.close()
|
||||
self._error_fd = None
|
||||
|
||||
def clear_logs(self):
|
||||
self._rmf(self._log_file)
|
||||
self._rmf(self._error_log)
|
||||
|
|
@ -87,7 +93,7 @@ class Dnsd:
|
|||
self._process.terminate()
|
||||
self._process.wait(timeout=2)
|
||||
self._process = None
|
||||
return not wait_dead or True
|
||||
self.close_log()
|
||||
return True
|
||||
|
||||
def restart(self):
|
||||
|
|
@ -122,8 +128,8 @@ class Dnsd:
|
|||
'--logfile', f'{self._log_file}',
|
||||
'--pidfile', f'{self._pid_file}',
|
||||
]
|
||||
procerr = open(self._error_log, 'a')
|
||||
self._process = subprocess.Popen(args=args, stderr=procerr)
|
||||
self._error_fd = open(self._error_log, 'a')
|
||||
self._process = subprocess.Popen(args=args, stderr=self._error_fd)
|
||||
if self._process.returncode is not None:
|
||||
return False
|
||||
return self.wait_live(timeout=timedelta(seconds=Env.SERVER_TIMEOUT))
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue