romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-26 10:37:22 +03:00
Code Issues Projects Releases Packages Wiki Activity

clang-tidy: sync argument names in prototype and definition

Browse source 
Discovered with clang-tidy checker
`readability-inconsistent-declaration-parameter-name`.

Also:
- do not enforce the above because of inconsistencies still present
  between public API prototypes and definitions. (Also betwen man page
  protos, and man page examples, and other parts of the code, e.g.
  `easy` vs `curl` vs `d` vs `handle`) Perhaps subject for a future
  effort:
  https://github.com/curl/curl/actions/runs/22166472728/job/64094691653
- enable and fix `readability-named-parameter` where missing.

Refs:
https://clang.llvm.org/extra/clang-tidy/checks/readability/inconsistent-declaration-parameter-name.html
https://clang.llvm.org/extra/clang-tidy/checks/readability/named-parameter.html

Closes #20624
This commit is contained in:
Viktor Szakats 2026-02-18 00:55:27 +01:00
parent 7c01bb23bc
commit c878160e9c
No known key found for this signature in database
64 changed files with 200 additions and 195 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/vssh/vssh.c
View file

@ -285,19 +285,19 @@ fail:
}
CURLcode Curl_ssh_range(struct Curl_easy *data,
const char *p, curl_off_t filesize,
const char *range, curl_off_t filesize,
curl_off_t *startp, curl_off_t *sizep)
{
curl_off_t from, to;
int to_t;
int from_t = curlx_str_number(&p, &from, CURL_OFF_T_MAX);
int from_t = curlx_str_number(&range, &from, CURL_OFF_T_MAX);
if(from_t == STRE_OVERFLOW)
return CURLE_RANGE_ERROR;
curlx_str_passblanks(&p);
(void)curlx_str_single(&p, '-');
curlx_str_passblanks(&range);
(void)curlx_str_single(&range, '-');
to_t = curlx_str_numblanks(&p, &to);
if((to_t == STRE_OVERFLOW) || (to_t && from_t) || *p)
to_t = curlx_str_numblanks(&range, &to);
if((to_t == STRE_OVERFLOW) || (to_t && from_t) || *range)
return CURLE_RANGE_ERROR;
if(from_t) {