romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-26 00:43:52 +03:00
Code Issues Projects Releases Packages Wiki Activity

clang-tidy: sync argument names in prototype and definition

Browse source 
Discovered with clang-tidy checker
`readability-inconsistent-declaration-parameter-name`.

Also:
- do not enforce the above because of inconsistencies still present
  between public API prototypes and definitions. (Also betwen man page
  protos, and man page examples, and other parts of the code, e.g.
  `easy` vs `curl` vs `d` vs `handle`) Perhaps subject for a future
  effort:
  https://github.com/curl/curl/actions/runs/22166472728/job/64094691653
- enable and fix `readability-named-parameter` where missing.

Refs:
https://clang.llvm.org/extra/clang-tidy/checks/readability/inconsistent-declaration-parameter-name.html
https://clang.llvm.org/extra/clang-tidy/checks/readability/named-parameter.html

Closes #20624
This commit is contained in:
Viktor Szakats 2026-02-18 00:55:27 +01:00
parent 7c01bb23bc
commit c878160e9c
No known key found for this signature in database
64 changed files with 200 additions and 195 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/vauth/cleartext.c
View file

@ -81,14 +81,14 @@ CURLcode Curl_auth_create_plain_message(const char *authzid,
*
* Parameters:
*
* valuep [in] - The username or user's password.
* value [in] - The username or user's password.
* out [out] - The result storage.
*
* Returns void.
*/
void Curl_auth_create_login_message(const char *valuep, struct bufref *out)
void Curl_auth_create_login_message(const char *value, struct bufref *out)
{
Curl_bufref_set(out, valuep, strlen(valuep), NULL);
Curl_bufref_set(out, value, strlen(value), NULL);
}
/*

8
lib/vauth/vauth.h
View file

@ -110,7 +110,7 @@ CURLcode Curl_auth_create_digest_http_message(struct Curl_easy *data,
const char *userp,
const char *passwdp,
const unsigned char *request,
const unsigned char *uri,
const unsigned char *uripath,
struct digestdata *digest,
char **outptr, size_t *outlen);
@ -150,7 +150,7 @@ CURLcode Curl_auth_gsasl_token(struct Curl_easy *data,
struct bufref *out);
/* This is used to clean up the gsasl specific data */
void Curl_auth_gsasl_cleanup(struct gsasldata *digest);
void Curl_auth_gsasl_cleanup(struct gsasldata *gsasl);
#endif
#ifdef USE_NTLM
@ -199,13 +199,13 @@ CURLcode Curl_auth_create_ntlm_type1_message(struct Curl_easy *data,
const char *userp,
const char *passwdp,
const char *service,
const char *host,
const char *hostname,
struct ntlmdata *ntlm,
struct bufref *out);
/* This is used to decode a base64 encoded NTLM type-2 message */
CURLcode Curl_auth_decode_ntlm_type2_message(struct Curl_easy *data,
const struct bufref *type2,
const struct bufref *type2ref,
struct ntlmdata *ntlm);
/* This is used to generate a base64 encoded NTLM type-3 message */