clang-tidy: sync argument names in prototype and definition

Discovered with clang-tidy checker
`readability-inconsistent-declaration-parameter-name`.

Also:
- do not enforce the above because of inconsistencies still present
  between public API prototypes and definitions. (Also betwen man page
  protos, and man page examples, and other parts of the code, e.g.
  `easy` vs `curl` vs `d` vs `handle`) Perhaps subject for a future
  effort:
  https://github.com/curl/curl/actions/runs/22166472728/job/64094691653
- enable and fix `readability-named-parameter` where missing.

Refs:
https://clang.llvm.org/extra/clang-tidy/checks/readability/inconsistent-declaration-parameter-name.html
https://clang.llvm.org/extra/clang-tidy/checks/readability/named-parameter.html

Closes #20624
This commit is contained in:
Viktor Szakats 2026-02-18 00:55:27 +01:00
parent 7c01bb23bc
commit c878160e9c
No known key found for this signature in database
64 changed files with 200 additions and 195 deletions

View file

@ -1015,20 +1015,20 @@ CURLcode Curl_resolv_blocking(struct Curl_easy *data,
const char *hostname,
int port,
int ip_version,
struct Curl_dns_entry **dnsentry)
struct Curl_dns_entry **entry)
{
CURLcode result;
DEBUGASSERT(hostname && *hostname);
*dnsentry = NULL;
result = Curl_resolv(data, hostname, port, ip_version, FALSE, dnsentry);
*entry = NULL;
result = Curl_resolv(data, hostname, port, ip_version, FALSE, entry);
switch(result) {
case CURLE_OK:
DEBUGASSERT(*dnsentry);
DEBUGASSERT(*entry);
return CURLE_OK;
case CURLE_AGAIN:
DEBUGASSERT(!*dnsentry);
result = Curl_async_await(data, dnsentry);
if(result || !*dnsentry) {
DEBUGASSERT(!*entry);
result = Curl_async_await(data, entry);
if(result || !*entry) {
/* close the connection, since we cannot return failure here without
cleaning up this connection properly. */
connclose(data->conn, "async resolve failed");