mirror of
https://github.com/curl/curl.git
synced 2026-04-14 22:31:41 +03:00
clang-tidy: sync argument names in prototype and definition
Discovered with clang-tidy checker `readability-inconsistent-declaration-parameter-name`. Also: - do not enforce the above because of inconsistencies still present between public API prototypes and definitions. (Also betwen man page protos, and man page examples, and other parts of the code, e.g. `easy` vs `curl` vs `d` vs `handle`) Perhaps subject for a future effort: https://github.com/curl/curl/actions/runs/22166472728/job/64094691653 - enable and fix `readability-named-parameter` where missing. Refs: https://clang.llvm.org/extra/clang-tidy/checks/readability/inconsistent-declaration-parameter-name.html https://clang.llvm.org/extra/clang-tidy/checks/readability/named-parameter.html Closes #20624
This commit is contained in:
parent
7c01bb23bc
commit
c878160e9c
64 changed files with 200 additions and 195 deletions
|
|
@ -380,14 +380,14 @@ out:
|
|||
* CURLE_OPERATION_TIMEDOUT if a time-out occurred, or other errors.
|
||||
*/
|
||||
CURLcode Curl_async_await(struct Curl_easy *data,
|
||||
struct Curl_dns_entry **entry)
|
||||
struct Curl_dns_entry **dns)
|
||||
{
|
||||
struct async_ares_ctx *ares = &data->state.async.ares;
|
||||
CURLcode result = CURLE_OK;
|
||||
timediff_t timeout_ms;
|
||||
|
||||
DEBUGASSERT(entry);
|
||||
*entry = NULL; /* clear on entry */
|
||||
DEBUGASSERT(dns);
|
||||
*dns = NULL; /* clear on entry */
|
||||
|
||||
timeout_ms = Curl_timeleft_ms(data);
|
||||
if(timeout_ms < 0) {
|
||||
|
|
@ -426,7 +426,7 @@ CURLcode Curl_async_await(struct Curl_easy *data,
|
|||
if(Curl_ares_perform(ares->channel, call_timeout_ms) < 0)
|
||||
return CURLE_UNRECOVERABLE_POLL;
|
||||
|
||||
result = Curl_async_is_resolved(data, entry);
|
||||
result = Curl_async_is_resolved(data, dns);
|
||||
if(result || data->state.async.done)
|
||||
break;
|
||||
|
||||
|
|
@ -449,7 +449,7 @@ CURLcode Curl_async_await(struct Curl_easy *data,
|
|||
/* Operation complete, if the lookup was successful we now have the entry
|
||||
in the cache. */
|
||||
data->state.async.done = TRUE;
|
||||
*entry = data->state.async.dns;
|
||||
*dns = data->state.async.dns;
|
||||
|
||||
if(result)
|
||||
ares_cancel(ares->channel);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue