From c4db274491cf27ba67986a73b58bdd170a608dcf Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Mon, 7 Jul 2025 23:46:21 +0200 Subject: [PATCH] try dropping Curl_cwcsdup --- lib/curl_memory.h | 5 +---- lib/curl_sspi.c | 1 + lib/easy.c | 6 ------ lib/setup-win32.h | 3 --- lib/vauth/vauth.c | 1 + lib/vtls/schannel.c | 1 + tests/libtest/memptr.c | 3 --- tests/server/memptr.c | 3 --- 8 files changed, 4 insertions(+), 19 deletions(-) diff --git a/lib/curl_memory.h b/lib/curl_memory.h index d0ea7f7ff7..b4536c1b3f 100644 --- a/lib/curl_memory.h +++ b/lib/curl_memory.h @@ -121,9 +121,6 @@ extern curl_free_callback Curl_cfree; extern curl_realloc_callback Curl_crealloc; extern curl_strdup_callback Curl_cstrdup; extern curl_calloc_callback Curl_ccalloc; -#if defined(_WIN32) && defined(UNICODE) -extern curl_wcsdup_callback Curl_cwcsdup; -#endif #ifndef CURLDEBUG @@ -150,7 +147,7 @@ extern curl_wcsdup_callback Curl_cwcsdup; #ifdef _WIN32 #undef _tcsdup #ifdef UNICODE -#define _tcsdup(ptr) Curl_cwcsdup(ptr) +#define _tcsdup(ptr) Curl_wcsdup(ptr) #else #define _tcsdup(ptr) Curl_cstrdup(ptr) #endif diff --git a/lib/curl_sspi.c b/lib/curl_sspi.c index 03ef4cf61c..5f19e960b9 100644 --- a/lib/curl_sspi.c +++ b/lib/curl_sspi.c @@ -28,6 +28,7 @@ #include #include "curl_sspi.h" +#include "strdup.h" #include "curlx/multibyte.h" #include "system_win32.h" #include "curlx/version_win32.h" diff --git a/lib/easy.c b/lib/easy.c index b90757d947..9c1f1c6969 100644 --- a/lib/easy.c +++ b/lib/easy.c @@ -129,9 +129,6 @@ curl_free_callback Curl_cfree = (curl_free_callback)free; curl_realloc_callback Curl_crealloc = (curl_realloc_callback)realloc; curl_strdup_callback Curl_cstrdup = (curl_strdup_callback)system_strdup; curl_calloc_callback Curl_ccalloc = (curl_calloc_callback)calloc; -#if defined(_WIN32) && defined(UNICODE) -curl_wcsdup_callback Curl_cwcsdup = (curl_wcsdup_callback)Curl_wcsdup; -#endif #if defined(_MSC_VER) && defined(_DLL) # pragma warning(pop) @@ -157,9 +154,6 @@ static CURLcode global_init(long flags, bool memoryfuncs) Curl_crealloc = (curl_realloc_callback)realloc; Curl_cstrdup = (curl_strdup_callback)system_strdup; Curl_ccalloc = (curl_calloc_callback)calloc; -#if defined(_WIN32) && defined(UNICODE) - Curl_cwcsdup = (curl_wcsdup_callback)Curl_wcsdup; -#endif } if(Curl_trc_init()) { diff --git a/lib/setup-win32.h b/lib/setup-win32.h index f95eacf62b..02177a7a3b 100644 --- a/lib/setup-win32.h +++ b/lib/setup-win32.h @@ -82,9 +82,6 @@ # include # include # include -# ifdef UNICODE - typedef wchar_t *(*curl_wcsdup_callback)(const wchar_t *str); -# endif #endif /* diff --git a/lib/vauth/vauth.c b/lib/vauth/vauth.c index d60991995d..7a85b7041f 100644 --- a/lib/vauth/vauth.c +++ b/lib/vauth/vauth.c @@ -27,6 +27,7 @@ #include #include "vauth.h" +#include "../strdup.h" #include "../urldata.h" #include "../curlx/multibyte.h" #include "../curl_printf.h" diff --git a/lib/vtls/schannel.c b/lib/vtls/schannel.c index f1edc2791c..2ac61ba794 100644 --- a/lib/vtls/schannel.c +++ b/lib/vtls/schannel.c @@ -44,6 +44,7 @@ #include "vtls_scache.h" #include "../sendf.h" #include "../connect.h" /* for the connect timeout */ +#include "../strdup.h" #include "../strerror.h" #include "../select.h" /* for the socket readiness */ #include "../curlx/inet_pton.h" /* for IP addr SNI check */ diff --git a/tests/libtest/memptr.c b/tests/libtest/memptr.c index ed6556a107..64e9fd7f8a 100644 --- a/tests/libtest/memptr.c +++ b/tests/libtest/memptr.c @@ -40,9 +40,6 @@ curl_free_callback Curl_cfree = (curl_free_callback)free; curl_realloc_callback Curl_crealloc = (curl_realloc_callback)realloc; curl_strdup_callback Curl_cstrdup = (curl_strdup_callback)strdup; curl_calloc_callback Curl_ccalloc = (curl_calloc_callback)calloc; -#if defined(_WIN32) && defined(UNICODE) -curl_wcsdup_callback Curl_cwcsdup = (curl_wcsdup_callback)_wcsdup; -#endif #if defined(_MSC_VER) && defined(_DLL) # pragma warning(pop) diff --git a/tests/server/memptr.c b/tests/server/memptr.c index 96187e5bf6..247bbf13ab 100644 --- a/tests/server/memptr.c +++ b/tests/server/memptr.c @@ -41,9 +41,6 @@ curl_free_callback Curl_cfree = (curl_free_callback)free; curl_realloc_callback Curl_crealloc = (curl_realloc_callback)realloc; curl_strdup_callback Curl_cstrdup = (curl_strdup_callback)system_strdup; curl_calloc_callback Curl_ccalloc = (curl_calloc_callback)calloc; -#if defined(_WIN32) && defined(UNICODE) -curl_wcsdup_callback Curl_cwcsdup = NULL; /* not used in test code */ -#endif #if defined(_MSC_VER) && defined(_DLL) # pragma warning(pop)