diff --git a/lib/transfer.c b/lib/transfer.c index d5eb2c3274..b9581d7adf 100644 --- a/lib/transfer.c +++ b/lib/transfer.c @@ -1717,12 +1717,19 @@ CURLcode Curl_follow(struct Curl_easy *data, break; case 303: /* See Other */ - /* Disable both types of POSTs, unless the user explicitly - asks for POST after POST */ - if(data->set.httpreq != HTTPREQ_GET - && !(data->set.keep_post & CURL_REDIR_POST_303)) { - data->set.httpreq = HTTPREQ_GET; /* enforce GET request */ - infof(data, "Disables POST, goes with %s\n", + /* 'See Other' location is not the resource but a substitute for the + * resource. In this case we switch the method to GET/HEAD, unless the + * method is POST and the user specified to keep it as POST. + * https://github.com/curl/curl/issues/5237#issuecomment-614641049 + */ + if(data->set.httpreq != HTTPREQ_GET && + ((data->set.httpreq != HTTPREQ_POST && + data->set.httpreq != HTTPREQ_POST_FORM && + data->set.httpreq != HTTPREQ_POST_MIME) || + !(data->set.keep_post & CURL_REDIR_POST_303))) { + data->set.httpreq = HTTPREQ_GET; + data->set.upload = false; + infof(data, "Switch to %s\n", data->set.opt_no_body?"HEAD":"GET"); } break; diff --git a/tests/data/Makefile.inc b/tests/data/Makefile.inc index 425a0c02f8..26faa954fe 100644 --- a/tests/data/Makefile.inc +++ b/tests/data/Makefile.inc @@ -178,7 +178,7 @@ test1450 test1451 test1452 test1453 test1454 test1455 test1456 test1457 \ test1458 test1459 test1500 test1501 test1502 test1503 test1504 test1505 \ test1506 test1507 test1508 test1509 test1510 test1511 test1512 test1513 \ test1514 test1515 test1516 test1517 test1518 test1519 test1520 test1521 \ -test1522 test1523 \ +test1522 test1523 test1524 \ \ test1525 test1526 test1527 test1528 test1529 test1530 test1531 test1532 \ test1533 test1534 test1535 test1536 test1537 test1538 \ diff --git a/tests/data/test1524 b/tests/data/test1524 new file mode 100644 index 0000000000..ed0c0476e1 --- /dev/null +++ b/tests/data/test1524 @@ -0,0 +1,77 @@ + + + +HTTP +HTTP PUT +followlocation + + +# +# Server-side + + +HTTP/1.1 303 OK swsclose +Location: moo.html&testcase=/15240002 +Connection: close + + + +HTTP/1.1 200 OK swsclose +Location: this should be ignored +Connection: close + +body + + +HTTP/1.1 303 OK swsclose +Location: moo.html&testcase=/15240002 +Connection: close + +HTTP/1.1 200 OK swsclose +Location: this should be ignored +Connection: close + +body + + + +# +# Client-side + + +http + + +HTTP PUT with 303 redirect + + +http://%HOSTIP:%HTTPPORT/blah/1524 -L -T log/upload1524.txt + + +moo + + + +# +# Verify data after the test has been "shot" + + +^User-Agent:.* + + +PUT /blah/1524 HTTP/1.1 +Host: %HOSTIP:%HTTPPORT +Accept: */* +Content-Length: 4 +Expect: 100-continue + +moo +GET /blah/moo.html&testcase=/15240002 HTTP/1.1 +User-Agent: this should be ignored +Host: %HOSTIP:%HTTPPORT +Accept: */* + + + + +