romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-05-13 13:56:19 +03:00
Code Issues Projects Releases Packages Wiki Activity

http: add asserts for null terminator for input strings

Browse source 
http_rw_hd() assumes the null terminator is present. These asserts make
sure this remains true.

Closes #19741
This commit is contained in:
Daniel Stenberg 2025-11-28 09:43:27 +01:00
parent 48939a4575
commit bfc3d131b6
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
2 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/http.c
View file

@ -4142,6 +4142,7 @@ static CURLcode http_rw_hd(struct Curl_easy *data,
CURLcode result = CURLE_OK;
struct SingleRequest *k = &data->req;
int writetype;
DEBUGASSERT(!hd[hdlen]); /* null terminated */
*pconsumed = 0;
if((0x0a == *hd) || (0x0d == *hd)) {
@ -4426,6 +4427,7 @@ CURLcode Curl_http_write_resp_hd(struct Curl_easy *data,
CURLcode result;
size_t consumed;
char tmp = 0;
DEBUGASSERT(!hd[hdlen]); /* null terminated */
result = http_rw_hd(data, hd, hdlen, &tmp, 0, &consumed);
if(!result && is_eos) {

1
lib/transfer.c
View file

@ -820,6 +820,7 @@ CURLcode Curl_xfer_write_resp_hd(struct Curl_easy *data,
const char *hd0, size_t hdlen, bool is_eos)
{
if(data->conn->handler->write_resp_hd) {
DEBUGASSERT(!hd0[hdlen]); /* null terminated */
/* protocol handlers offering this function take full responsibility
* for writing all received download data to the client. */
return data->conn->handler->write_resp_hd(data, hd0, hdlen, is_eos);