romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-06-02 03:24:16 +03:00
Code Issues Projects Releases Packages Wiki Activity

tests: torture: don't duplicate valgrind command

Browse source 
When running torture tests with valgrind enabled, the torture function
got a command line that already had the valgrind invocation in it. It
added another, at the end resulting in an empty valgrind log file.

Remove the duplicate logic adding valgrind, which already had a bit of
different logic that wasn't updated when the other one was.

Closes #17501
This commit is contained in:
Yedaya Katsman 2025-06-04 21:22:35 +03:00 • committed by Daniel Stenberg
parent 1d9c1e4b0f
commit bc7d88cc8a
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 0 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/runner.pm
View file

@ -502,19 +502,6 @@ sub torture {
unlink("$LOGDIR/$MEMDUMP");
my $cmd = $testcmd;
if($valgrind && !$gdbthis) {
my @valgrindoption = getpart("verify", "valgrind");
if((!@valgrindoption) || ($valgrindoption[0] !~ /disable/)) {
my $valgrindcmd = shell_quote($valgrind) . " ";
$valgrindcmd .= "$valgrind_tool " if($valgrind_tool);
$valgrindcmd .= "--quiet --leak-check=yes ";
$valgrindcmd .= "--suppressions=$srcdir/valgrind.supp ";
# $valgrindcmd .= "--gen-suppressions=all ";
$valgrindcmd .= "--num-callers=16 ";
$valgrindcmd .= "${valgrind_logfile}=$LOGDIR/valgrind$testnum";
$cmd = "$valgrindcmd $testcmd";
}
}
logmsg "*** Function number $limit is now set to fail ***\n" if($gdbthis);
my $ret = 0;