cookie: use origin scheme for secure context check

`Curl_secure_context()` checked `conn->scheme` to determine if Secure
cookies may be sent. Since 73daec6, `conn->scheme` is set to the proxy's
scheme when using an HTTPS forwarding proxy, causing the function to
return TRUE for HTTP origins. This leaked Secure cookies over the
plaintext connection between proxy and origin.

Use `data->state.origin->scheme` instead, which always reflects the
origin's scheme regardless of proxy configuration.

Not an approved vulnerability because the regression was introduced
after the last release and is not present in any released version.

Verified by test 3401

Follow-up to 73daec6620
Reported-by: daviey on hackerone
URL: https://hackerone.com/reports/3803415
Closes #22024
This commit is contained in:
Dave Walker 2026-06-15 12:57:42 +01:00 committed by Daniel Stenberg
parent 50ffc359e9
commit b9702f8c48
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
5 changed files with 64 additions and 11 deletions

View file

@ -286,6 +286,7 @@ test3216 test3217 test3218 test3219 test3220 test3221 test3222 \
test3300 test3301 test3302 test3303 test3304 test3305 \
\
test3400 \
test3401 \
\
test4000 test4001

55
tests/data/test3401 Normal file
View file

@ -0,0 +1,55 @@
<?xml version="1.0" encoding="US-ASCII"?>
<testcase>
<info>
<keywords>
HTTP
HTTPS proxy
cookies
Secure
</keywords>
</info>
# Server-side
<reply>
<data crlf="headers">
HTTP/1.1 200 OK
Content-Length: 4
foo
</data>
</reply>
# Client-side
<client>
<server>
http
https-proxy
</server>
<features>
HTTPS-proxy
cookies
</features>
<name>
HTTP via HTTPS proxy does not send Secure cookies
</name>
<command>
-x https://%HOSTIP:%HTTPSPROXYPORT --proxy-insecure -b %LOGDIR/jar%TESTNUMBER.txt http://test.example/%TESTNUMBER
</command>
<file name="%LOGDIR/jar%TESTNUMBER.txt">
# Netscape HTTP Cookie File
test.example FALSE / TRUE 9999999999 session secret
</file>
</client>
# Verify data after the test has been "shot"
<verify>
<proxy crlf="headers">
GET http://test.example/%TESTNUMBER HTTP/1.1
Host: test.example
User-Agent: curl/%VERSION
Accept: */*
Proxy-Connection: Keep-Alive
</proxy>
</verify>
</testcase>