From b7ecd14725fdfe63bf84f63829dd63fb2e8cba3f Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Thu, 19 Feb 2026 15:47:00 +0100 Subject: [PATCH] clang-tidy: replace comma-separated string with list in config Bump required clang-tidy version to v17.0.0 for this. Ref: https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-tidy/index.html Follow-up to 4497dbd9ac4a31b0056a9179d500676ebe091de5 #20605 Closes #20632 --- .clang-tidy.yml | 28 +++++++++++++--------------- docs/INTERNALS.md | 2 +- 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/.clang-tidy.yml b/.clang-tidy.yml index f9187b439b..705060a988 100644 --- a/.clang-tidy.yml +++ b/.clang-tidy.yml @@ -4,18 +4,16 @@ --- # https://clang.llvm.org/extra/clang-tidy/checks/list.html -# -clang-analyzer-security.insecureAPI.bzero: for FD_ZERO() (seen on macOS) -# -clang-analyzer-security.ArrayBound: due to false positives with clang-tidy v21.1.0 -Checks: >- - -clang-analyzer-security.insecureAPI.bzero, - -clang-analyzer-optin.performance.Padding, - -clang-analyzer-security.ArrayBound, - -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling, - -clang-diagnostic-nullability-extension, - bugprone-suspicious-realloc-usage, - misc-const-correctness, - portability-*, - readability-named-parameter, - readability-redundant-control-flow, - readability-redundant-preprocessor, - readability-uppercase-literal-suffix +Checks: + - -clang-analyzer-security.insecureAPI.bzero # for FD_ZERO() (seen on macOS) + - -clang-analyzer-optin.performance.Padding + - -clang-analyzer-security.ArrayBound # due to false positives with clang-tidy v21.1.0 + - -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling + - -clang-diagnostic-nullability-extension + - bugprone-suspicious-realloc-usage + - misc-const-correctness + - portability-* + - readability-named-parameter + - readability-redundant-control-flow + - readability-redundant-preprocessor + - readability-uppercase-literal-suffix diff --git a/docs/INTERNALS.md b/docs/INTERNALS.md index 5d77d4306b..3a21ad678b 100644 --- a/docs/INTERNALS.md +++ b/docs/INTERNALS.md @@ -49,7 +49,7 @@ When writing code (mostly for generating stuff included in release tarballs) we use a few "build tools" and we make sure that we remain functional with these versions: -- clang-tidy 14.0.0 (2022-03-23), recommended: 19.1.0 or later (2024-09-17) +- clang-tidy 17.0.0 (2023-09-19), recommended: 19.1.0 or later (2024-09-17) - cmake 3.7 (2016-11-11) - GNU autoconf 2.59 (2003-11-06) - GNU automake 1.7 (2002-09-25)