mirror of
https://github.com/curl/curl.git
synced 2026-07-29 03:13:07 +03:00
stop using the word 'just'
Everywhere. In documentation and code comments. It is almost never a good word and almost always a filler that should be avoided. Closes #20793
This commit is contained in:
parent
4b583b7585
commit
b4dba346cd
213 changed files with 727 additions and 772 deletions
|
|
@ -112,7 +112,7 @@ add_executable(curlinfo EXCLUDE_FROM_ALL "curlinfo.c")
|
|||
target_link_libraries(curlinfo PRIVATE ${CURL_LIBS})
|
||||
set_target_properties(curlinfo PROPERTIES UNITY_BUILD OFF)
|
||||
|
||||
# special libcurltool library just for unittests
|
||||
# special libcurltool library for unittests
|
||||
add_library(curltool STATIC EXCLUDE_FROM_ALL ${CURL_CFILES} ${CURL_HFILES} ${_curlx_cfiles_lib} ${_curlx_hfiles_lib})
|
||||
target_compile_definitions(curltool PUBLIC "CURL_STATICLIB" "UNITTESTS")
|
||||
target_link_libraries(curltool PUBLIC ${CURL_LIBS})
|
||||
|
|
|
|||
|
|
@ -249,7 +249,7 @@ static long tlsversion(unsigned char mintls,
|
|||
tlsver = CURL_SSLVERSION_TLSv1_2;
|
||||
break;
|
||||
case 4:
|
||||
default: /* just in case */
|
||||
default: /* in case */
|
||||
tlsver = CURL_SSLVERSION_TLSv1_3;
|
||||
break;
|
||||
}
|
||||
|
|
@ -266,7 +266,7 @@ static long tlsversion(unsigned char mintls,
|
|||
tlsver |= CURL_SSLVERSION_MAX_TLSv1_2;
|
||||
break;
|
||||
case 4:
|
||||
default: /* just in case */
|
||||
default: /* in case */
|
||||
tlsver |= CURL_SSLVERSION_MAX_TLSv1_3;
|
||||
break;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -228,8 +228,7 @@ int tool_debug_cb(CURL *handle, curl_infotype type,
|
|||
if(!traced_data) {
|
||||
/* if the data is output to a tty and we are sending this debug trace
|
||||
to stderr or stdout, we do not display the alert about the data not
|
||||
being shown as the data _is_ shown then just not via this
|
||||
function */
|
||||
being shown as the data _is_ shown then not via this function */
|
||||
if(!global->isatty ||
|
||||
((output != tool_stderr) && (output != stdout))) {
|
||||
if(!newl)
|
||||
|
|
|
|||
|
|
@ -235,7 +235,7 @@ int tool_write_headers(struct HdrCbData *hdrcbdata, FILE *stream)
|
|||
struct curl_slist *h = hdrcbdata->headlist;
|
||||
int rc = 1;
|
||||
while(h) {
|
||||
/* not "handled", just show it */
|
||||
/* not "handled", show it */
|
||||
size_t len = strlen(h->data);
|
||||
if(len != fwrite(h->data, 1, len, stream))
|
||||
goto fail;
|
||||
|
|
@ -536,7 +536,7 @@ size_t tool_header_cb(char *ptr, size_t size, size_t nmemb, void *userdata)
|
|||
#endif
|
||||
}
|
||||
else
|
||||
/* not "handled", just show it */
|
||||
/* not "handled", show it */
|
||||
fwrite(ptr, cb, 1, outs->stream);
|
||||
}
|
||||
return cb;
|
||||
|
|
|
|||
|
|
@ -226,7 +226,7 @@ void progressbarinit(struct ProgressData *bar, struct OperationConfig *config)
|
|||
memset(bar, 0, sizeof(struct ProgressData));
|
||||
|
||||
/* pass the resume from value through to the progress function so it can
|
||||
* display progress towards total file not just the part that is left. */
|
||||
* display progress towards total file not the part that is left. */
|
||||
if(config->use_resume)
|
||||
bar->initial_size = config->resume_from;
|
||||
|
||||
|
|
|
|||
|
|
@ -77,7 +77,7 @@ int tool_seek_cb(void *userdata, curl_off_t offset, int whence)
|
|||
#endif
|
||||
|
||||
if(curl_lseek(per->infd, offset, whence) == LSEEK_ERROR)
|
||||
/* could not rewind, the reason is in errno but errno is just not portable
|
||||
/* could not rewind, the reason is in errno but errno is not portable
|
||||
enough and we do not actually care that much why we failed. We will let
|
||||
libcurl know that it may try other means if it wants to. */
|
||||
return CURL_SEEKFUNC_CANTSEEK;
|
||||
|
|
|
|||
|
|
@ -821,7 +821,7 @@ int formparse(const char *input,
|
|||
SET_TOOL_MIME_PTR(part, type);
|
||||
SET_TOOL_MIME_PTR(part, encoder);
|
||||
|
||||
/* *contp could be '\0', so we just check with the delimiter */
|
||||
/* *contp could be '\0', so we check with the delimiter */
|
||||
} while(sep); /* loop if there is another filename */
|
||||
part = (*mimecurrent)->subparts; /* Set name on group. */
|
||||
}
|
||||
|
|
|
|||
|
|
@ -421,7 +421,7 @@ UNITTEST ParameterError parse_cert_parameter(const char *cert_parameter,
|
|||
memcpy(certname_place, param_place, span);
|
||||
param_place += span;
|
||||
certname_place += span;
|
||||
/* we just ate all the non-special chars. now we are on either a special
|
||||
/* we ate all the non-special chars. now we are on either a special
|
||||
* char or the end of the string. */
|
||||
switch(*param_place) {
|
||||
case '\0':
|
||||
|
|
@ -1270,7 +1270,7 @@ static ParameterError parse_ech(struct OperationConfig *config,
|
|||
} /* file done */
|
||||
}
|
||||
else {
|
||||
/* Simple case: just a string, with a keyword */
|
||||
/* Simple case: a string, with a keyword */
|
||||
err = getstr(&config->ech, nextarg, DENY_BLANK);
|
||||
}
|
||||
return err;
|
||||
|
|
@ -1415,7 +1415,7 @@ static ParameterError parse_quote(struct OperationConfig *config,
|
|||
err = add2list(&config->postquote, nextarg);
|
||||
break;
|
||||
case '+':
|
||||
/* prefixed with a plus makes it a just-before-transfer one */
|
||||
/* prefixed with a plus makes it an immediately-before-transfer one */
|
||||
nextarg++;
|
||||
err = add2list(&config->prequote, nextarg);
|
||||
break;
|
||||
|
|
@ -3115,7 +3115,7 @@ ParameterError parse_args(int argc, argv_item_t argv[])
|
|||
else {
|
||||
bool used;
|
||||
|
||||
/* Just add the URL please */
|
||||
/* add the URL please */
|
||||
err = getparameter("--url", orig_opt, &used, config, 0);
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -181,7 +181,7 @@ CURLcode ipfs_url_rewrite(CURLU *uh, const char *protocol, char **url,
|
|||
curl_url_set(uh, CURLUPART_PORT, gwport, CURLU_URLENCODE))
|
||||
goto clean;
|
||||
|
||||
/* if the input path is just a slash, clear it */
|
||||
/* if the input path is a slash, clear it */
|
||||
if(inputpath && (inputpath[0] == '/') && !inputpath[1])
|
||||
*inputpath = '\0';
|
||||
|
||||
|
|
|
|||
|
|
@ -55,8 +55,8 @@ static void voutf(const char *prefix, const char *fmt, va_list ap)
|
|||
cut--;
|
||||
}
|
||||
if(cut == 0)
|
||||
/* not a single cutting position was found, just cut it at the
|
||||
max text width then! */
|
||||
/* not a single cutting position was found, cut it at the max text
|
||||
width then! */
|
||||
cut = width - 1;
|
||||
|
||||
(void)fwrite(ptr, cut + 1, 1, tool_stderr);
|
||||
|
|
|
|||
|
|
@ -554,17 +554,17 @@ static CURLcode retrycheck(struct OperationConfig *config,
|
|||
/* truncate file at the position where we started appending */
|
||||
#if defined(HAVE_FTRUNCATE) && !defined(__DJGPP__) && !defined(__AMIGA__)
|
||||
if(ftruncate(fileno(outs->stream), outs->init)) {
|
||||
/* when truncate fails, we cannot just append as then we will
|
||||
/* when truncate fails, we cannot append as then we will
|
||||
create something strange, bail out */
|
||||
errorf("Failed to truncate file");
|
||||
return CURLE_WRITE_ERROR;
|
||||
}
|
||||
/* now seek to the end of the file, the position where we
|
||||
just truncated the file in a large file-safe way */
|
||||
truncated the file in a large file-safe way */
|
||||
rc = fseek(outs->stream, 0, SEEK_END);
|
||||
#else
|
||||
/* ftruncate is not available, so just reposition the file
|
||||
to the location we would have truncated it. */
|
||||
/* ftruncate is not available, so reposition the file to the location
|
||||
we would have truncated it. */
|
||||
rc = curlx_fseek(outs->stream, outs->init, SEEK_SET);
|
||||
#endif
|
||||
if(rc) {
|
||||
|
|
@ -951,7 +951,7 @@ static CURLcode setup_headerfile(struct OperationConfig *config,
|
|||
* Since every transfer has its own file handle for dumping
|
||||
* the headers, we need to open it in append mode, since transfers
|
||||
* might finish in any order.
|
||||
* The first transfer just clears the file.
|
||||
* The first transfer clears the file.
|
||||
*
|
||||
* Consider placing the file handle inside the OperationConfig, so
|
||||
* that it does not need to be opened/closed for every transfer.
|
||||
|
|
@ -1995,7 +1995,7 @@ static CURLcode serial_transfers(CURLSH *share)
|
|||
bailout = TRUE;
|
||||
else {
|
||||
do {
|
||||
/* setup the next one just before we delete this */
|
||||
/* setup the next one before we delete this */
|
||||
result = create_transfer(share, &added, &skipped);
|
||||
if(result) {
|
||||
returncode = result;
|
||||
|
|
|
|||
|
|
@ -492,8 +492,8 @@ CURLcode glob_url(struct URLGlob *glob, const char *url, curl_off_t *urlnum,
|
|||
FILE *error)
|
||||
{
|
||||
/*
|
||||
* We can deal with any-size, just make a buffer with the same length
|
||||
* as the specified URL!
|
||||
* We can deal with any-size, make a buffer with the same length as the
|
||||
* specified URL!
|
||||
*/
|
||||
curl_off_t amount = 0;
|
||||
CURLcode result;
|
||||
|
|
|
|||
|
|
@ -619,7 +619,7 @@ static void separator(const char *sep, size_t seplen, FILE *stream)
|
|||
case '\0':
|
||||
break;
|
||||
default:
|
||||
/* unknown, just output this */
|
||||
/* unknown, output this */
|
||||
fputc(sep[0], stream);
|
||||
fputc(sep[1], stream);
|
||||
break;
|
||||
|
|
@ -834,7 +834,7 @@ void ourWriteOut(struct OperationConfig *config, struct per_transfer *per,
|
|||
fputs("%output{", stream);
|
||||
}
|
||||
else {
|
||||
/* illegal syntax, then just output the characters that are used */
|
||||
/* illegal syntax, then output the characters that are used */
|
||||
fputc('%', stream);
|
||||
fputc(ptr[1], stream);
|
||||
ptr += 2;
|
||||
|
|
@ -853,7 +853,7 @@ void ourWriteOut(struct OperationConfig *config, struct per_transfer *per,
|
|||
fputc('\t', stream);
|
||||
break;
|
||||
default:
|
||||
/* unknown, just output this */
|
||||
/* unknown, output this */
|
||||
fputc(*ptr, stream);
|
||||
fputc(ptr[1], stream);
|
||||
break;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue