romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-25 21:33:36 +03:00
Code Issues Projects Releases Packages Wiki Activity

tests: silence some Perl::Critic warnings in test suite

Browse source 
Not all warnings are fixed; many are as much stylistic suggestions than
anything and IMHO don't do much to actually improve the code.

Ref: #10818
Closes #10861
This commit is contained in:
Dan Fandrich 2023-03-27 19:58:00 -07:00
parent b5cb9a5a36
commit b133f70a52
7 changed files with 186 additions and 197 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/sshhelp.pm
View file

@ -26,7 +26,6 @@ package sshhelp;
use strict;
use warnings;
use Exporter;
use File::Spec;
@ -34,7 +33,6 @@ use File::Spec;
# Global symbols allowed without explicit package name
#
use vars qw(
@ISA
@EXPORT_OK
$sshdexe
$sshexe
@ -64,7 +62,7 @@ use vars qw(
#***************************************************************************
# Inherit Exporter's capabilities
#
@ISA = qw(Exporter);
use base qw(Exporter);
#***************************************************************************
@ -214,7 +212,7 @@ sub dump_array {
}
elsif(open(TEXTFH, ">$filename")) {
foreach my $line (@arr) {
$line .= "\n" unless($line =~ /\n$/);
$line .= "\n" if($line !~ /\n$/);
print TEXTFH $line;
}
if(!close(TEXTFH)) {
@ -319,6 +317,7 @@ sub find_file {
return $file;
}
}
return "";
}
@ -337,6 +336,7 @@ sub find_exe_file {
return $file if(($xext) && (lc($file) =~ /\Q$xext\E$/));
}
}
return "";
}
@ -420,6 +420,7 @@ sub find_httptlssrv {
}
return $p if($found);
}
return "";
}