mirror of
https://github.com/curl/curl.git
synced 2026-07-30 20:38:03 +03:00
tidy-up: miscellaneous
- tool_bname: scope an include. - `endif` comments. - Markdown fixes. - comment tidy-ups. - whitespace, newlines, indent. Closes #20309
This commit is contained in:
parent
62ba3604dc
commit
ac6264366f
98 changed files with 829 additions and 863 deletions
|
|
@ -224,9 +224,9 @@ How to write git commit messages in the curl project.
|
|||
The first line is a succinct description of the change and should ideally work
|
||||
as a single line in the RELEASE NOTES.
|
||||
|
||||
- use the imperative, present tense: **change** not "changed" nor "changes"
|
||||
- do not capitalize the first letter
|
||||
- no period (.) at the end
|
||||
- use the imperative, present tense: **change** not "changed" nor "changes"
|
||||
- do not capitalize the first letter
|
||||
- no period (.) at the end
|
||||
|
||||
The `[area]` in the first line can be `http2`, `cookies`, `openssl` or
|
||||
similar. There is no fixed list to select from but using the same "area" as
|
||||
|
|
@ -238,36 +238,36 @@ Use the following ways to improve the message and provide pointers to related
|
|||
work.
|
||||
|
||||
- `Follow-up to {shorthash}` - if this fixes or continues a previous commit;
|
||||
add a `Ref:` that commit's PR or issue if it is not a small, obvious fix;
|
||||
followed by an empty line
|
||||
add a `Ref:` that commit's PR or issue if it is not a small, obvious fix;
|
||||
followed by an empty line
|
||||
|
||||
- `Bug: URL` to the source of the report or more related discussion; use
|
||||
`Fixes` for GitHub issues instead when that is appropriate.
|
||||
`Fixes` for GitHub issues instead when that is appropriate.
|
||||
|
||||
- `Approved-by: John Doe` - credit someone who approved the PR.
|
||||
|
||||
- `Authored-by: John Doe` - credit the original author of the code; only use
|
||||
this if you cannot use `git commit --author=...`.
|
||||
this if you cannot use `git commit --author=...`.
|
||||
|
||||
- `Signed-off-by: John Doe` - we do not use this, but do not bother removing
|
||||
it.
|
||||
|
||||
- `whatever-else-by:` credit all helpers, finders, doers; try to use one of
|
||||
the following keywords if at all possible, for consistency: `Acked-by:`,
|
||||
`Assisted-by:`, `Co-authored-by:`, `Found-by:`, `Reported-by:`,
|
||||
`Reviewed-by:`, `Suggested-by:`, `Tested-by:`.
|
||||
the following keywords if at all possible, for consistency: `Acked-by:`,
|
||||
`Assisted-by:`, `Co-authored-by:`, `Found-by:`, `Reported-by:`,
|
||||
`Reviewed-by:`, `Suggested-by:`, `Tested-by:`.
|
||||
|
||||
- `Ref: #1234` - if this is related to a GitHub issue or PR, possibly one that
|
||||
has already been closed.
|
||||
has already been closed.
|
||||
|
||||
- `Ref: URL` to more information about the commit; use `Bug:` instead for a
|
||||
reference to a bug on another bug tracker]
|
||||
reference to a bug on another bug tracker]
|
||||
|
||||
- `Fixes #1234` - if this fixes a GitHub issue; GitHub closes the issue once
|
||||
this commit is merged.
|
||||
this commit is merged.
|
||||
|
||||
- `Closes #1234` - if this merges a GitHub PR; GitHub closes the PR once this
|
||||
commit is merged.
|
||||
commit is merged.
|
||||
|
||||
Do not forget to use commit with `--author` if you commit someone else's work,
|
||||
and make sure that you have your own user and email setup correctly in git
|
||||
|
|
@ -289,7 +289,8 @@ Just ask if this is what you would want. You are required to have posted
|
|||
several high quality patches first, before you can be granted push access.
|
||||
|
||||
## Useful resources
|
||||
- [Webinar on getting code into curl](https://youtu.be/QmZ3W1d6LQI)
|
||||
|
||||
- [Webinar on getting code into curl](https://youtu.be/QmZ3W1d6LQI)
|
||||
|
||||
# Update copyright and license information
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue