romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-05-30 06:47:28 +03:00
Code Issues Projects Releases Packages Wiki Activity

rustls: fix clang-tidy warning

Browse source 
Seen with v21.1.1, non-debug-enabled build:
```
lib/vtls/rustls.c:415:23: error: File position of the stream might be 'indeterminate'
after a failed operation. Can cause undefined behavior [clang-analyzer-unix.Stream,-warnings-as-errors]
  415 |     const size_t rr = fread(buf, 1, sizeof(buf), f);
      |                       ^
```
Ref: https://github.com/curl/curl/actions/runs/17898248031/job/50887746633?pr=18660#step:11:174

Cherry-picked from #18660
Closes #18670
This commit is contained in:
Viktor Szakats 2025-09-21 21:55:30 +02:00
parent c9eff26c17
commit aa9fa4d68e
No known key found for this signature in database
GPG key ID: B5ABD165E2AEF201
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/vtls/rustls.c
View file

@ -410,7 +410,7 @@ read_file_into(const char *filename,
return 0;
}
while(!feof(f)) {
for(;;) {
uint8_t buf[256];
const size_t rr = fread(buf, 1, sizeof(buf), f);
if(rr == 0 ||
@ -418,6 +418,8 @@ read_file_into(const char *filename,
fclose(f);
return 0;
}
if(rr < sizeof(buf))
break;
}
return fclose(f) == 0;