romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-14 22:31:41 +03:00
Code Issues Projects Releases Packages Wiki Activity

tests/server/sockfilt: check for NULL tv to silence clang-tidy

Browse source 
A NULL dereference cannot happen with existing use of this code.

linux-mingw, CM clang-tidy:
```
/home/runner/work/curl/curl/tests/server/sockfilt.c:720:24: error: Access
 to field 'tv_sec' results in a dereference of a null pointer (loaded from
 variable 'tv') [clang-analyzer-core.NullDereference,-warnings-as-errors]
  720 |             tv->tv_sec = 0;
      |             ~~         ^
```
Ref: https://github.com/curl/curl/actions/runs/22191200093/job/64179197235?pr=20631#step:10:283

Cherry-picked from #20631

Closes #20639
This commit is contained in:
Viktor Szakats 2026-02-19 18:34:35 +01:00
parent 4042e7d9d8
commit aa1854a8ff
No known key found for this signature in database
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/server/sockfilt.c
View file

@ -717,8 +717,10 @@ static int select_ws(int nfds, fd_set *readfds, fd_set *writefds,
data[nws].wsasock = wsasock;
data[nws].wsaevent = wsaevent;
data[nfd].wsastate = 0;
tv->tv_sec = 0;
tv->tv_usec = 0;
if(tv) {
tv->tv_sec = 0;
tv->tv_usec = 0;
}
/* check if the socket is already ready */
if(select(fd + 1, &readsock, &writesock, &exceptsock, tv) == 1) {
logmsg("[select_ws] socket %d is ready", fd);