mirror of
https://github.com/curl/curl.git
synced 2026-08-07 21:12:55 +03:00
digest: escape control codes too
Since the username is decoded when used and control codes are accepted in HTTP usernames in general, the username encoding for the Digest auth needs to percent encode such bytes. Verified by test 3221 Reported-by: Trail of Bits Closes #21915
This commit is contained in:
parent
04afd16076
commit
a2b943b115
3 changed files with 81 additions and 1 deletions
74
tests/data/test3221
Normal file
74
tests/data/test3221
Normal file
|
|
@ -0,0 +1,74 @@
|
|||
<?xml version="1.0" encoding="US-ASCII"?>
|
||||
<testcase>
|
||||
<info>
|
||||
<keywords>
|
||||
HTTP
|
||||
HTTP GET
|
||||
digest
|
||||
</keywords>
|
||||
</info>
|
||||
|
||||
# Server-side
|
||||
<reply>
|
||||
<data crlf="headers">
|
||||
HTTP/1.1 401 Authorization Required
|
||||
WWW-Authenticate: Digest realm="testrealm%0a%0d", nonce="1053604145"
|
||||
Content-Length: 4
|
||||
|
||||
hej
|
||||
</data>
|
||||
|
||||
<data1000 crlf="headers">
|
||||
HTTP/1.1 200 OK
|
||||
Content-Length: 23
|
||||
|
||||
This IS the real page!
|
||||
</data1000>
|
||||
|
||||
<datacheck crlf="headers">
|
||||
HTTP/1.1 401 Authorization Required
|
||||
WWW-Authenticate: Digest realm="testrealm%0a%0d", nonce="1053604145"
|
||||
Content-Length: 4
|
||||
|
||||
HTTP/1.1 200 OK
|
||||
Content-Length: 23
|
||||
|
||||
This IS the real page!
|
||||
</datacheck>
|
||||
</reply>
|
||||
|
||||
# Client-side
|
||||
<client>
|
||||
<server>
|
||||
http
|
||||
</server>
|
||||
<features>
|
||||
!SSPI
|
||||
crypto
|
||||
digest
|
||||
</features>
|
||||
<name>
|
||||
HTTP Digest with CRLF in username
|
||||
</name>
|
||||
<command>
|
||||
http://hello%0a%0d:there@%HOSTIP:%HTTPPORT/ --digest
|
||||
</command>
|
||||
</client>
|
||||
|
||||
# Verify data after the test has been "shot"
|
||||
<verify>
|
||||
<protocol crlf="headers">
|
||||
GET / HTTP/1.1
|
||||
Host: %HOSTIP:%HTTPPORT
|
||||
User-Agent: curl/%VERSION
|
||||
Accept: */*
|
||||
|
||||
GET / HTTP/1.1
|
||||
Host: %HOSTIP:%HTTPPORT
|
||||
Authorization: Digest username="hello%0A%0D", realm="testrealm%0a%0d", nonce="1053604145", uri="/", response="64e5ae1b90f05309847ac483c1094284"
|
||||
User-Agent: curl/%VERSION
|
||||
Accept: */*
|
||||
|
||||
</protocol>
|
||||
</verify>
|
||||
</testcase>
|
||||
Loading…
Add table
Add a link
Reference in a new issue