From 9f25dcea55713aa37451c52b809e16ae1509bfe4 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Mon, 15 Jun 2026 13:51:52 +0200 Subject: [PATCH] checksrc: detect and warn for (void)! It's plain weird. Don't do it. Closes #22023 --- scripts/checksrc.pl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/checksrc.pl b/scripts/checksrc.pl index b09ded9bfe..2f2c218fea 100755 --- a/scripts/checksrc.pl +++ b/scripts/checksrc.pl @@ -202,6 +202,7 @@ my %warnings = ( 'TYPEDEFSTRUCT' => 'typedefed struct', 'UNUSEDIGNORE' => 'a warning ignore was not used', 'USESAFEFREE' => 'replace curlx_free() + NULL assignment with curlx_safefree()', + 'VOIDEXCL' => '(void)! is not something we like', ); sub readskiplist { @@ -1165,6 +1166,12 @@ sub scanfile { "space after exclamation mark"); } + if($nostr =~ /(.*)\(void\)\!/) { + checkwarn("VOIDEXCL", + $line, length($1)+1, $file, $ol, + "exclamation after (void) is weird"); + } + if($nostr =~ /(.*)\b(EACCES|EADDRINUSE|EADDRNOTAVAIL|EAFNOSUPPORT|EBADF|ECONNREFUSED|ECONNRESET|EINPROGRESS|EINTR|EINVAL|EISCONN|EMSGSIZE|ENOMEM|ETIMEDOUT|EWOULDBLOCK)\b/) { checkwarn("ERRNOVAR", $line, length($1), $file, $ol,