romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-20 12:01:13 +03:00
Code Issues Projects Releases Packages Wiki Activity

libssh2: error check and null-terminate in ssh_state_sftp_readdir_link()

Browse source 
- null-terminate the result to match the other getter
  `libssh2_sftp_symlink_ex()` call.

- check negative result and bail out early.

Reported-by: Joshua Rogers

Closes #18598
This commit is contained in:
Viktor Szakats 2025-09-18 14:02:51 +02:00
parent cec6c1cd9c
commit 9f18cb6544
No known key found for this signature in database
GPG key ID: B5ABD165E2AEF201
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/vssh/libssh2.c
View file

@ -2405,6 +2405,12 @@ static CURLcode ssh_state_sftp_readdir_link(struct Curl_easy *data,
curlx_dyn_free(&sshp->readdir_link);
if(rc < 0)
return CURLE_OUT_OF_MEMORY;
/* It seems that this string is not always null-terminated */
sshp->readdir_filename[rc] = '\0';
/* append filename and extra output */
result = curlx_dyn_addf(&sshp->readdir, " -> %s", sshp->readdir_filename);
if(result)