romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-06-19 01:25:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

tidy-up: drop stray comparisons with literal zero

Browse source 
Drop from:
- strcmp, strcmpi, strncmp, memcmp, lstat, getrlimit, setrlimit, fseek,
  fstat
- autotools detection snippets.
- smooth-gtk-thread: simplify `!var != 0` expression.

Closes #21947
This commit is contained in:
Viktor Szakats 2026-06-10 13:03:41 +02:00
parent 2f3fa479dd
commit 97aed9c960
No known key found for this signature in database
43 changed files with 142 additions and 143 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/examples/anyauthput.c
View file

@ -109,7 +109,7 @@ int main(int argc, const char **argv)
if(!fp)
return 2;
if(fstat(fileno(fp), &file_info) != 0) {
if(fstat(fileno(fp), &file_info)) {
fclose(fp);
return 1; /* cannot continue */
}

2
docs/examples/ephiperfifo.c
View file

@ -412,7 +412,7 @@ static int init_fifo(struct GlobalInfo *g)
struct epoll_event epev;
fprintf(MSG_OUT, "Creating named pipe \"%s\"\n", fifo);
if(lstat(fifo, &st) == 0) {
if(!lstat(fifo, &st)) {
if((st.st_mode & S_IFMT) == S_IFREG) {
errno = EEXIST;
perror("lstat");

2
docs/examples/evhiperfifo.c
View file

@ -382,7 +382,7 @@ static int init_fifo(struct GlobalInfo *g)
curl_socket_t sockfd;
fprintf(MSG_OUT, "Creating named pipe \"%s\"\n", fifo);
if(lstat(fifo, &st) == 0) {
if(!lstat(fifo, &st)) {
if((st.st_mode & S_IFMT) == S_IFREG) {
errno = EEXIST;
perror("lstat");

2
docs/examples/fileupload.c
View file

@ -64,7 +64,7 @@ int main(void)
}
/* to get the file size */
if(fstat(fileno(fd), &file_info) != 0) {
if(fstat(fileno(fd), &file_info)) {
fclose(fd);
curl_global_cleanup();
return 1; /* cannot continue */

2
docs/examples/ftpupload.c
View file

@ -96,7 +96,7 @@ int main(void)
}
/* to get the file size */
if(fstat(fileno(hd_src), &file_info) != 0) {
if(fstat(fileno(hd_src), &file_info)) {
fclose(hd_src);
return 1; /* cannot continue */
}

2
docs/examples/ghiper.c
View file

@ -399,7 +399,7 @@ int init_fifo(void)
const char *fifo = "hiper.fifo";
int socket;
if(lstat(fifo, &st) == 0) {
if(!lstat(fifo, &st)) {
if((st.st_mode & S_IFMT) == S_IFREG) {
errno = EEXIST;
perror("lstat");

2
docs/examples/hiperfifo.c
View file

@ -383,7 +383,7 @@ static int init_fifo(struct GlobalInfo *g)
curl_socket_t sockfd;
fprintf(MSG_OUT, "Creating named pipe \"%s\"\n", fifo);
if(lstat(fifo, &st) == 0) {
if(!lstat(fifo, &st)) {
if((st.st_mode & S_IFMT) == S_IFREG) {
errno = EEXIST;
perror("lstat");

2
docs/examples/http2-upload.c
View file

@ -234,7 +234,7 @@ static int setup(struct input *t, int num, const char *upload)
return 1;
}
if(fstat(fileno(t->in), &file_info) != 0) {
if(fstat(fileno(t->in), &file_info)) {
fprintf(stderr, "error: could not stat file %s: %s\n", upload,
strerror(errno));
fclose(t->out);

2
docs/examples/httpput.c
View file

@ -96,7 +96,7 @@ int main(int argc, const char **argv)
return 2;
/* get the file size of the local file */
if(fstat(fileno(hd_src), &file_info) != 0) {
if(fstat(fileno(hd_src), &file_info)) {
fclose(hd_src);
return 1; /* cannot continue */
}

2
docs/examples/smooth-gtk-thread.c
View file

@ -210,7 +210,7 @@ int main(int argc, const char **argv)
g_signal_connect(G_OBJECT(top_window), "delete-event",
G_CALLBACK(cb_delete), NULL);
if(!g_thread_create(&create_thread, progress_bar, FALSE, NULL) != 0)
if(!g_thread_create(&create_thread, progress_bar, FALSE, NULL))
g_warning("cannot create the thread");
gtk_main();

16
docs/examples/synctime.c
View file

@ -149,7 +149,7 @@ static size_t SyncTime_CURL_WriteHeader(void *ptr, size_t size, size_t nmemb,
int i;
SYSTime.wMilliseconds = 500; /* adjust to midpoint, 0.5 sec */
for(i = 0; i < 12; i++) {
if(strcmp(MthStr[i], TmpStr2) == 0) {
if(!strcmp(MthStr[i], TmpStr2)) {
SYSTime.wMonth = (WORD)(i + 1);
break;
}
@ -232,26 +232,26 @@ int main(int argc, const char *argv[])
if(argc > 1) {
int OptionIndex = 1;
while(OptionIndex < argc) {
if(strncmp(argv[OptionIndex], "--server=", 9) == 0)
if(!strncmp(argv[OptionIndex], "--server=", 9))
snprintf(conf.timeserver, sizeof(conf.timeserver) - 1, "%s",
&argv[OptionIndex][9]);
if(strcmp(argv[OptionIndex], "--showall") == 0)
if(!strcmp(argv[OptionIndex], "--showall"))
ShowAllHeader = 1;
if(strcmp(argv[OptionIndex], "--synctime") == 0)
if(!strcmp(argv[OptionIndex], "--synctime"))
AutoSyncTime = 1;
if(strncmp(argv[OptionIndex], "--proxy-user=", 13) == 0)
if(!strncmp(argv[OptionIndex], "--proxy-user=", 13))
snprintf(conf.proxy_user, sizeof(conf.proxy_user) - 1, "%s",
&argv[OptionIndex][13]);
if(strncmp(argv[OptionIndex], "--proxy=", 8) == 0)
if(!strncmp(argv[OptionIndex], "--proxy=", 8))
snprintf(conf.http_proxy, sizeof(conf.http_proxy) - 1, "%s",
&argv[OptionIndex][8]);
if((strcmp(argv[OptionIndex], "--help") == 0) ||
(strcmp(argv[OptionIndex], "/?") == 0)) {
if(!strcmp(argv[OptionIndex], "--help") ||
!strcmp(argv[OptionIndex], "/?")) {
showUsage();
return 0;
}