romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-23 17:47:15 +03:00
Code Issues Projects Releases Packages Wiki Activity

ip-happy: prevent event-based stall on retry

Browse source 
When delaying an IP happy eyeball restart, set an actual timer or the
connection will stall when running event based.

Closes #18815
This commit is contained in:
Stefan Eissing 2025-10-02 16:39:37 +02:00 • committed by Daniel Stenberg
parent e5316069f1
commit 95ac33fc4f
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

14
lib/cf-ip-happy.c
View file

@ -461,10 +461,10 @@ evaluate:
else if(inconclusive) {
/* tried all addresses, no success but some where inconclusive.
* Let's restart the inconclusive ones. */
if(curlx_timediff(now, bs->last_attempt_started) >=
bs->attempt_delay_ms) {
CURL_TRC_CF(data, cf, "tried all addresses with inconclusive results"
", restarting one");
timediff_t since_ms = curlx_timediff(now, bs->last_attempt_started);
timediff_t delay_ms = bs->attempt_delay_ms - since_ms;
if(delay_ms <= 0) {
CURL_TRC_CF(data, cf, "all attempts inconclusive, restarting one");
i = -1;
for(a = bs->running; a; a = a->next) {
++i;
@ -479,6 +479,12 @@ evaluate:
}
DEBUGASSERT(0); /* should not come here */
}
else {
/* let's wait some more before restarting */
infof(data, "connect attempts inconclusive, retrying "
"in %" FMT_TIMEDIFF_T "ms", delay_ms);
Curl_expire(data, delay_ms, EXPIRE_HAPPY_EYEBALLS);
}
/* attempt timeout for restart has not expired yet */
goto out;
}