romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-26 14:53:33 +03:00
Code Issues Projects Releases Packages Wiki Activity

all: remove FIXME and TODO comments

Browse source 
We can always improve. These comments tend to linger and go misleading
or plain wrong over time.

Closes #16283
This commit is contained in:
Daniel Stenberg 2025-02-10 11:20:48 +01:00
parent f1d1c98b7f
commit 94c596bbc5
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
23 changed files with 51 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/conncache.c
View file

@ -166,11 +166,11 @@ int Curl_cpool_init(struct cpool *cpool,
if(!cpool->idata)
return 1; /* bad */
cpool->idata->state.internal = TRUE;
/* TODO: this is quirky. We need an internal handle for certain
* operations, but we do not add it to the multi (if there is one).
* But we give it the multi so that socket event operations can work.
* Probably better to have an internal handle owned by the multi that
* can be used for cpool operations. */
/* This is quirky. We need an internal handle for certain operations, but we
* do not add it to the multi (if there is one). We give it the multi so
* that socket event operations can work. Probably better to have an
* internal handle owned by the multi that can be used for cpool
* operations. */
cpool->idata->multi = multi;
#ifdef DEBUGBUILD
if(getenv("CURL_DEBUG"))
@ -1302,7 +1302,6 @@ static int conn_upkeep(struct Curl_easy *data,
void *param)
{
struct curltime *now = param;
/* TODO, shall we reap connections that return an error here? */
Curl_conn_upkeep(data, conn, now);
return 0; /* continue iteration */
}