mirror of
https://github.com/curl/curl.git
synced 2026-05-30 07:07:30 +03:00
cmake: fix clang-tidy builds to verify tests, fix fallouts
- cmake: disable test bundles for clang-tidy builds. clang-tidy ignores #included .c sources, and incompatible with unity and bundles. It caused clang-tidy ignoring all test sources. It also means this is the first time tests sources are checked with clang-tidy. (autotools doesn't run it on tests.) - cmake: update description for `CURL_TEST_BUNDLES` option. - fix tests using special `CURLE_*` enums that were missing from `curl/curl.h`. Add them as reserved codes. - fix about ~50 other issues detected by clang-tidy: unchecked results, NULL derefs, memory leaks, casts to enums, unused assigments, uninitialized `errno` uses, unchecked `open`, indent, and more. - drop unnecessary casts (lib1533, lib3207). - suppress a few impossible cases with detailed `NOLINT`s. - lib/escape.c: drop `NOLINT` no longer necessary. Follow-up to72abf7c13a#13862 (possibly) - extend two existing `NOLINT` comments with details. Follow-up tofabfa8e402#15825 Closes #16756
This commit is contained in:
parent
efa65b24ae
commit
9465327084
52 changed files with 257 additions and 179 deletions
|
|
@ -66,11 +66,11 @@ static void test_parse(
|
|||
fail_unless(!!exp_host == !!host, "host expectation failed");
|
||||
|
||||
if(!unitfail) {
|
||||
fail_unless(!exp_dev || strcmp(dev, exp_dev) == 0,
|
||||
fail_unless(!dev || !exp_dev || strcmp(dev, exp_dev) == 0,
|
||||
"dev should be equal to exp_dev");
|
||||
fail_unless(!exp_iface || strcmp(iface, exp_iface) == 0,
|
||||
fail_unless(!iface || !exp_iface || strcmp(iface, exp_iface) == 0,
|
||||
"iface should be equal to exp_iface");
|
||||
fail_unless(!exp_host || strcmp(host, exp_host) == 0,
|
||||
fail_unless(!host || !exp_host || strcmp(host, exp_host) == 0,
|
||||
"host should be equal to exp_host");
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue