From 946306b3e5f62f52ff72db85506eb5b789c4e66d Mon Sep 17 00:00:00 2001 From: Stefan Eissing Date: Thu, 11 Jun 2026 08:29:22 +0200 Subject: [PATCH] cf-ip-happy: update documentation Reported-by: correctmost on github Fixes #21957 Closes #21959 --- lib/cf-ip-happy.c | 10 ---------- lib/cf-ip-happy.h | 19 +++++++++++-------- 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/lib/cf-ip-happy.c b/lib/cf-ip-happy.c index 5f99db59d3..92f15ff347 100644 --- a/lib/cf-ip-happy.c +++ b/lib/cf-ip-happy.c @@ -989,16 +989,6 @@ struct Curl_cftype Curl_cft_ip_happy = { cf_ip_happy_query, }; -/** - * Create an IP happy eyeball connection filter that uses the, once resolved, - * address information to connect on ip families based on connection - * configuration. - * @param pcf output, the created cfilter - * @param data easy handle used in creation - * @param conn connection the filter is created for - * @param cf_create method to create the sub-filters performing the - * actual connects. - */ static CURLcode cf_ip_happy_create(struct Curl_cfilter **pcf, struct Curl_easy *data, struct Curl_peer *origin, diff --git a/lib/cf-ip-happy.h b/lib/cf-ip-happy.h index d2994aad43..dd9b29ac8f 100644 --- a/lib/cf-ip-happy.h +++ b/lib/cf-ip-happy.h @@ -33,18 +33,15 @@ struct Curl_peer; struct Curl_sockaddr_ex; /** - * Create a cfilter for making an "ip" connect to a peer. + * Create a cfilter to connect to `origin` via an optional `peer` + * using `transport_peer` and `addr`. + * With a `tunnel_peer` present, the filter will be used to proxy tunnel + * to it and the tunnel will use `tunnel_transport`. * `pcf`: the filter created on success * `data`: the transfer initiating the connect - * `peer`: the peer to connect to - * `transport_peer': the transport used for the peer connect * `conn`: the connection that gets connected - * `addr`: the socket address to connect to - * `tunnel_peer`: NULL or the peer to tunnel through - * `tunnel_transport`: the transport that goes through the tunnel * - * Such a filter may be used in "happy eyeball" scenarios, and its - * `connect` implementation needs to support non-blocking. Once connected, + * The filter is used in "happy eyeball" scenarios. Once connected, * it MAY be installed in the connection filter chain to serve transfers. */ typedef CURLcode cf_ip_connect_create(struct Curl_cfilter **pcf, @@ -57,6 +54,12 @@ typedef CURLcode cf_ip_connect_create(struct Curl_cfilter **pcf, struct Curl_peer *tunnel_peer, uint8_t tunnel_transport); +/** + * Create an IP happy eyeball connection filter that connects to `origin` + * via an optional `peer` using `transport_peer`. + * With a `tunnel_peer` present, the filter will be used to proxy tunnel + * to it and the tunnel will use `tunnel_transport`. + */ CURLcode cf_ip_happy_insert_after(struct Curl_cfilter *cf_at, struct Curl_easy *data, struct Curl_peer *origin,