mirror of
https://github.com/curl/curl.git
synced 2026-08-25 22:13:33 +03:00
cleanup: remove FIXME and TODO comments
They serve very little purpose and mostly just add noise. Most of them have been around for a very long time. I read them all before removing or rephrasing them. Ref: #3876 Closes #3883
This commit is contained in:
parent
f506ce099f
commit
8ece8177f1
36 changed files with 33 additions and 152 deletions
|
|
@ -34,11 +34,11 @@ void config_init(struct OperationConfig* config)
|
|||
config->use_httpget = FALSE;
|
||||
config->create_dirs = FALSE;
|
||||
config->maxredirs = DEFAULT_MAXREDIRS;
|
||||
config->proto = CURLPROTO_ALL; /* FIXME: better to read from library */
|
||||
config->proto = CURLPROTO_ALL;
|
||||
config->proto_present = FALSE;
|
||||
config->proto_redir = CURLPROTO_ALL & /* All except FILE, SCP and SMB */
|
||||
~(CURLPROTO_FILE | CURLPROTO_SCP | CURLPROTO_SMB |
|
||||
CURLPROTO_SMBS);
|
||||
~(CURLPROTO_FILE | CURLPROTO_SCP | CURLPROTO_SMB |
|
||||
CURLPROTO_SMBS);
|
||||
config->proto_redir_present = FALSE;
|
||||
config->proto_default = NULL;
|
||||
config->tcp_nodelay = TRUE; /* enabled by default */
|
||||
|
|
|
|||
|
|
@ -568,7 +568,6 @@ static int get_param_part(struct OperationConfig *config, char endchar,
|
|||
endpos--;
|
||||
sep = *p;
|
||||
*endpos = '\0';
|
||||
/* TODO: maybe special fopen for VMS? */
|
||||
fp = fopen(hdrfile, FOPEN_READTEXT);
|
||||
if(!fp)
|
||||
warnf(config->global, "Cannot read from %s: %s\n", hdrfile,
|
||||
|
|
|
|||
|
|
@ -101,7 +101,6 @@ CURLcode curl_easy_perform_ev(CURL *easy);
|
|||
static bool is_fatal_error(CURLcode code)
|
||||
{
|
||||
switch(code) {
|
||||
/* TODO: Should CURLE_PEER_FAILED_VERIFICATION be a critical error? */
|
||||
case CURLE_FAILED_INIT:
|
||||
case CURLE_OUT_OF_MEMORY:
|
||||
case CURLE_UNKNOWN_OPTION:
|
||||
|
|
@ -876,8 +875,6 @@ static CURLcode operate_do(struct GlobalConfig *global,
|
|||
|
||||
#if !defined(CURL_DISABLE_PROXY)
|
||||
{
|
||||
/* TODO: Make this a run-time check instead of compile-time one. */
|
||||
|
||||
my_setopt_str(curl, CURLOPT_PROXY, config->proxy);
|
||||
/* new in libcurl 7.5 */
|
||||
if(config->proxy)
|
||||
|
|
@ -1663,10 +1660,6 @@ static CURLcode operate_do(struct GlobalConfig *global,
|
|||
* file (or terminal). If we write to a file, we must rewind
|
||||
* or close/re-open the file so that the next attempt starts
|
||||
* over from the beginning.
|
||||
*
|
||||
* TODO: similar action for the upload case. We might need
|
||||
* to start over reading from a previous point if we have
|
||||
* uploaded something when this was returned.
|
||||
*/
|
||||
break;
|
||||
}
|
||||
|
|
@ -1757,8 +1750,6 @@ static CURLcode operate_do(struct GlobalConfig *global,
|
|||
download was not successful. */
|
||||
long response;
|
||||
if(CURLE_OK == result) {
|
||||
/* TODO We want to try next resource when download was
|
||||
not successful. How to know that? */
|
||||
char *effective_url = NULL;
|
||||
curl_easy_getinfo(curl, CURLINFO_EFFECTIVE_URL, &effective_url);
|
||||
if(effective_url &&
|
||||
|
|
@ -1932,9 +1923,6 @@ static CURLcode operate_do(struct GlobalConfig *global,
|
|||
break;
|
||||
mlres = mlres->next;
|
||||
if(mlres == NULL)
|
||||
/* TODO If metalink_next_res is 1 and mlres is NULL,
|
||||
* set res to error code
|
||||
*/
|
||||
break;
|
||||
}
|
||||
else if(urlnum > 1) {
|
||||
|
|
|
|||
|
|
@ -553,8 +553,7 @@ CURLcode glob_next_url(char **globbed, URLGlob *glob)
|
|||
}
|
||||
}
|
||||
if(carry) { /* first pattern ptr has run into overflow, done! */
|
||||
/* TODO: verify if this should actually return CURLE_OK. */
|
||||
return CURLE_OK; /* CURLE_OK to match previous behavior */
|
||||
return CURLE_OK;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue