From 8b7e460cce7dcfdc7f5f19e4d35a677593bce162 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Fri, 24 Apr 2026 09:53:21 +0200 Subject: [PATCH] checksrc: add missing items to warnings hash, alpha-sort Closes #21434 --- scripts/checksrc.pl | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/scripts/checksrc.pl b/scripts/checksrc.pl index 6569c83bc0..db7521fa37 100755 --- a/scripts/checksrc.pl +++ b/scripts/checksrc.pl @@ -154,8 +154,8 @@ my %warnings = ( 'BRACEELSE' => '} else on the same line', 'BRACEPOS' => 'wrong position for an open brace', 'BRACEWHILE' => 'A single space between open brace and while', - 'COMMANOSPACE' => 'comma without following space', 'CLOSEBRACE' => 'close brace indent level vs line above is off', + 'COMMANOSPACE' => 'comma without following space', 'COMMENTNOSPACEEND' => 'no space before */', 'COMMENTNOSPACESTART' => 'no space following /*', 'COPYRIGHT' => 'file missing a copyright statement', @@ -164,8 +164,8 @@ my %warnings = ( 'DOBRACE' => 'A single space between do and open brace', 'EMPTYLINEBRACE' => 'Empty line before the open brace', 'EQUALSNOSPACE' => 'equals sign without following space', - 'EQUALSPACE' => 'equals sign with too many spaces following', 'EQUALSNULL' => 'if/while comparison with == NULL', + 'EQUALSPACE' => 'equals sign with too many spaces following', 'ERRNOVAR' => 'use of bare errno define', 'EXCLAMATIONSPACE' => 'Whitespace after exclamation mark in expression', 'FIXME' => 'FIXME or TODO comment', @@ -174,23 +174,26 @@ my %warnings = ( 'INCLUDEDUP' => 'same file is included again', 'INDENTATION' => 'wrong start column for code', 'LONGLINE' => "Line longer than $max_column", - 'SPACEBEFORELABEL' => 'labels not at the start of the line', 'MULTISPACE' => 'multiple spaces used when not suitable', 'NOSPACEAND' => 'missing space around Logical AND operator', 'NOSPACEC' => 'missing space around ternary colon operator', 'NOSPACEEQUALS' => 'equals sign without preceding space', + 'NOSPACEPLUS' => 'no space before plus sign', 'NOSPACEQ' => 'missing space around ternary question mark operator', 'NOSPACETHAN' => 'missing space around less or greater than', 'NOTEQUALSZERO' => 'if/while comparison with != 0', 'ONELINECONDITION' => 'conditional block on the same line as the if()', 'OPENCOMMENT' => 'file ended with a /* comment still "open"', 'PARENBRACE' => '){ without sufficient space', + 'PLUSNOSPACE' => 'no space after plus sign', 'RETURNNOSPACE' => 'return without space', + 'RETURNPAREN' => 'return with paren', 'SEMINOSPACE' => 'semicolon without following space', 'SIZEOFNOPAREN' => 'use of sizeof without parentheses', 'SPACEAFTERPAREN' => 'space after open parenthesis', 'SPACEBEFORECLOSE' => 'space before a close parenthesis', 'SPACEBEFORECOMMA' => 'space before a comma', + 'SPACEBEFORELABEL' => 'labels not at the start of the line', 'SPACEBEFOREPAREN' => 'space before an open parenthesis', 'SPACESEMICOLON' => 'space before semicolon', 'SPACESWITCHCOLON' => 'space before colon of switch label',