romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-06-21 01:45:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

h3proxy: no stream userdata

Browse source 
Do not set the easy handle opening a proxy tunnel as userdata on the
stream. The ease handle might go out of scope long before the tunnel
stream is closed.

Closes #21962
This commit is contained in:
Stefan Eissing 2026-06-11 09:37:46 +02:00 • committed by Daniel Stenberg
parent 946306b3e5
commit 8a867c2062
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/vquic/cf-ngtcp2-proxy.c
View file

@ -934,18 +934,17 @@ static CURLcode cf_h3_proxy_submit(struct Curl_cfilter *cf,
int rv;
DEBUGASSERT(stream->id == -1);
rv = ngtcp2_conn_open_bidi_stream(ctx->qconn, &sid, data);
/* Do NOT set `data` as stream user data. The transfer `data` may
* get cleaned up long before the tunnel goes down. */
rv = ngtcp2_conn_open_bidi_stream(ctx->qconn, &sid, NULL);
if(rv) {
failf(data, "cannot get bidi streams: %s", ngtcp2_strerror(rv));
result = CURLE_SEND_ERROR;
goto out;
}
stream->id = sid;
++ctx->used_bidi_streams;
/* Do NOT set `data` as stream user data. The transfer `data` may
* get cleaned up long before the tunnel goes down. */
ts->stream = stream;
++ctx->used_bidi_streams;
CURL_TRC_CF(data, cf, "[%" PRId64 "] opened bidi stream", sid);
}