romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-05-30 04:07:27 +03:00
Code Issues Projects Releases Packages Wiki Activity

msvc: drop exception, make BIT() a bitfield with Visual Studio

Browse source 
Add casts to `bool`, or use `bit` type in local variables, where
neccessary to avoid MSVC compiler warnings C4242.

Note: There may remain places needing the above updates, where not
tested in CI, and missed in manual review.

Also:
- urldata: convert struct field `connect_only` to bitfield to match its
  counterpart in another struct.
- rename curl-specific `bit` type to `curl_bit`.

Closes #20142
This commit is contained in:
Viktor Szakats 2026-01-01 16:38:56 +01:00
parent 57ff2d6c91
commit 85c841cb45
No known key found for this signature in database
GPG key ID: B5ABD165E2AEF201
32 changed files with 73 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/tool_cb_wrt.c
View file

@ -244,7 +244,7 @@ size_t tool_write_cb(char *buffer, size_t sz, size_t nmemb, void *userdata)
struct OutStruct *outs = &per->outs;
struct OperationConfig *config = per->config;
size_t bytes = sz * nmemb;
bool is_tty = global->isatty;
bool is_tty = (bool)global->isatty;
#ifdef _WIN32
CONSOLE_SCREEN_BUFFER_INFO console_info;
intptr_t fhnd;

8
src/tool_operate.c
View file

@ -1166,8 +1166,8 @@ static CURLcode create_single(struct OperationConfig *config,
CURLSH *share, struct State *state,
bool *added, bool *skipped)
{
const bool orig_isatty = global->isatty;
const bool orig_noprogress = global->noprogress;
const bool orig_isatty = (bool)global->isatty;
const bool orig_noprogress = (bool)global->noprogress;
CURLcode result = CURLE_OK;
while(state->urlnode) {
struct per_transfer *per = NULL;
@ -2174,8 +2174,8 @@ static CURLcode run_all_transfers(CURLSH *share,
CURLcode result)
{
/* Save the values of noprogress and isatty to restore them later on */
bool orig_noprogress = global->noprogress;
bool orig_isatty = global->isatty;
bool orig_noprogress = (bool)global->noprogress;
bool orig_isatty = (bool)global->isatty;
struct per_transfer *per;
/* Time to actually do the transfers */