romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-01 11:58:04 +03:00
Code Issues Projects Releases Packages Wiki Activity

Curl_addr2string: take an addrlen argument too

Browse source 
This allows the function to figure out if a unix domain socket has a
file name or not associated with it! When a socket is created with
socketpair(), as done in the fuzzer testing, the path struct member is
uninitialized and must not be accessed.

Bug: https://crbug.com/oss-fuzz/16699

Closes #4283
This commit is contained in:
Daniel Stenberg 2019-08-30 11:29:55 +02:00
parent cd68dfe831
commit 84ced9389e
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
5 changed files with 24 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/unit/unit1607.c
View file

@ -150,7 +150,7 @@ UNITTEST_START
if(tests[i].address[j] == &skip)
continue;
if(addr && !Curl_addr2string(addr->ai_addr,
if(addr && !Curl_addr2string(addr->ai_addr, addr->ai_addrlen,
ipaddress, &port)) {
fprintf(stderr, "%s:%d tests[%d] failed. getaddressinfo failed.\n",
__FILE__, __LINE__, i);

2
tests/unit/unit1609.c
View file

@ -150,7 +150,7 @@ UNITTEST_START
if(!addr && !tests[i].address[j])
break;
if(addr && !Curl_addr2string(addr->ai_addr,
if(addr && !Curl_addr2string(addr->ai_addr, addr->ai_addrlen,
ipaddress, &port)) {
fprintf(stderr, "%s:%d tests[%d] failed. Curl_addr2string failed.\n",
__FILE__, __LINE__, i);