romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-25 02:37:18 +03:00
Code Issues Projects Releases Packages Wiki Activity

checksrc: modernise perl file open

Browse source 
Use regular variables and separate file open modes from filenames.

Suggested by perlcritic

Copied from f2784a9240

Closes #11358
This commit is contained in:
Paul Wise 2023-06-21 10:50:27 +02:00 • committed by Daniel Stenberg
parent 0526525c33
commit 7f669aa0f1
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
scripts/checksrc.pl
View file

@ -99,13 +99,13 @@ my %warnings = (
);
sub readskiplist {
open(W, "<$dir/checksrc.skip") or return;
my @all=<W>;
open(my $W, '<', "$dir/checksrc.skip") or return;
my @all=<$W>;
for(@all) {
$windows_os ? $_ =~ s/\r?\n$// : chomp;
$skiplist{$_}=1;
}
close(W);
close($W);
}
# Reads the .checksrc in $dir for any extended warnings to enable locally.
@ -381,7 +381,7 @@ sub scanfile {
my $l = "";
my $prep = 0;
my $prevp = 0;
open(R, "<$file") || die "failed to open $file";
open(my $R, '<', $file) || die "failed to open $file";
my $incomment=0;
my @copyright=();
@ -389,7 +389,7 @@ sub scanfile {
checksrc_clear(); # for file based ignores
accept_violations();
while(<R>) {
while(<$R>) {
$windows_os ? $_ =~ s/\r?\n$// : chomp;
my $l = $_;
my $ol = $l; # keep the unmodified line for error reporting
@ -939,7 +939,7 @@ sub scanfile {
checksrc_endoffile($file);
close(R);
close($R);
}