From 7d295145eb7ea07bbf8d4a0cf433f31c3f1ed585 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Fri, 24 Apr 2026 17:23:05 +0200 Subject: [PATCH] mbedtls: remove failf() call with first argument as NULL failf() needs an easy handle to work. This change removes the call since there is normnally nowhere to show the output if init fails. Bonus: improve language in an infof() call Spotted by Copilot Closes #21441 --- lib/vtls/mbedtls.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/vtls/mbedtls.c b/lib/vtls/mbedtls.c index 6f90f44cb2..e2822668f0 100644 --- a/lib/vtls/mbedtls.c +++ b/lib/vtls/mbedtls.c @@ -425,7 +425,7 @@ static void mbed_extract_certinfo(struct Curl_easy *data, cert_count++; if(cert_count > MAX_ALLOWED_CERT_AMOUNT) { - infof(data, "Certificates is more than allowed (%d), skipping certinfo", + infof(data, "More certificates than allowed (%d), skipping certinfo", MAX_ALLOWED_CERT_AMOUNT); return; } @@ -1513,11 +1513,9 @@ static int mbedtls_init(void) ret = mbedtls_ctr_drbg_seed(&rng.drbg, mbedtls_entropy_func, &rng.entropy, NULL, 0); - if(ret) { - failf(NULL, "failed: mbedtls_ctr_drbg_seed returned -0x%x", - (unsigned int)-ret); + if(ret) + /* mbedtls_ctr_drbg_seed returned error */ return 0; - } /* To prevent an adversary from reading your random data, you can enable prediction resistance.