romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-23 21:47:34 +03:00
Code Issues Projects Releases Packages Wiki Activity

quiche: fix possible leaks on teardown

Browse source 
When the close of the quiche filter was never called, the destroy function
did not release all allicated resources.

When closing a quiche filter, set the connected flag to FALSE.

Reported-by: Joshua Rogers
Closes #18880
This commit is contained in:
Stefan Eissing 2025-10-06 13:05:14 +02:00 • committed by Daniel Stenberg
parent e9ababe9aa
commit 762ce8801b
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
lib/vquic/curl_quiche.c
View file

@ -147,14 +147,22 @@ static void cf_quiche_ctx_free(struct cf_quiche_ctx *ctx)
static void cf_quiche_ctx_close(struct cf_quiche_ctx *ctx)
{
if(ctx->h3c)
if(ctx->h3c) {
quiche_h3_conn_free(ctx->h3c);
if(ctx->h3config)
ctx->h3c = NULL;
}
if(ctx->h3config) {
quiche_h3_config_free(ctx->h3config);
if(ctx->qconn)
ctx->h3config = NULL;
}
if(ctx->qconn) {
quiche_conn_free(ctx->qconn);
if(ctx->cfg)
ctx->qconn = NULL;
}
if(ctx->cfg) {
quiche_config_free(ctx->cfg);
ctx->cfg = NULL;
}
}
static CURLcode cf_flush_egress(struct Curl_cfilter *cf,
@ -1494,6 +1502,7 @@ static void cf_quiche_close(struct Curl_cfilter *cf, struct Curl_easy *data)
bool done;
(void)cf_quiche_shutdown(cf, data, &done);
cf_quiche_ctx_close(cf->ctx);
cf->connected = FALSE;
}
}
@ -1501,6 +1510,7 @@ static void cf_quiche_destroy(struct Curl_cfilter *cf, struct Curl_easy *data)
{
(void)data;
if(cf->ctx) {
cf_quiche_ctx_close(cf->ctx);
cf_quiche_ctx_free(cf->ctx);
cf->ctx = NULL;
}