romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-14 18:11:40 +03:00
Code Issues Projects Releases Packages Wiki Activity

slist: constify Curl_slist_append_nodup() string argument

Browse source 
Although finally stored as a non-const pointer, the string is intended
to be left unchanged.

This change allows using the function without the need of a cast for
const pointers.

Closes #19692
This commit is contained in:
Patrick Monnerat 2025-11-24 14:57:38 +01:00 • committed by Daniel Stenberg
parent 92e6782d1f
commit 74bd3e2f98
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/slist.c
View file

@ -58,7 +58,8 @@ static struct curl_slist *slist_get_last(struct curl_slist *list)
* If an error occurs, NULL is returned and the string argument is NOT
* released.
*/
struct curl_slist *Curl_slist_append_nodup(struct curl_slist *list, char *data)
struct curl_slist *Curl_slist_append_nodup(struct curl_slist *list,
const char *data)
{
struct curl_slist *last;
struct curl_slist *new_item;
@ -70,7 +71,7 @@ struct curl_slist *Curl_slist_append_nodup(struct curl_slist *list, char *data)
return NULL;
new_item->next = NULL;
new_item->data = data;
new_item->data = CURL_UNCONST(data);
/* if this is the first item, then new_item *is* the list */
if(!list)

2
lib/slist.h
View file

@ -36,6 +36,6 @@ struct curl_slist *Curl_slist_duplicate(struct curl_slist *inlist);
* it to the list.
*/
struct curl_slist *Curl_slist_append_nodup(struct curl_slist *list,
char *data);
const char *data);
#endif /* HEADER_CURL_SLIST_H */