From 72f2ab5f1e85da73329984a3da19d6292d4c0318 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Sat, 6 Jun 2026 14:24:29 +0200 Subject: [PATCH] build: enable `-Wlogical-op` picky warning for GCC 4.4+ --- CMake/PickyWarnings.cmake | 1 + m4/curl-compilers.m4 | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/CMake/PickyWarnings.cmake b/CMake/PickyWarnings.cmake index a4f0d52c9b..1ce5f7bda6 100644 --- a/CMake/PickyWarnings.cmake +++ b/CMake/PickyWarnings.cmake @@ -300,6 +300,7 @@ if(PICKY_COMPILER) list(APPEND _picky_enable -Wdouble-promotion # clang 3.6 gcc 4.6 appleclang 6.1 -Wformat=2 # clang 2.7 gcc 4.8 + -Wlogical-op # gcc 4.4 -Wtrampolines # gcc 4.6 ) endif() diff --git a/m4/curl-compilers.m4 b/m4/curl-compilers.m4 index 6a2e3c5102..36688bcff7 100644 --- a/m4/curl-compilers.m4 +++ b/m4/curl-compilers.m4 @@ -1115,6 +1115,11 @@ AC_DEFUN([CURL_SET_COMPILER_WARNING_OPTS], [ tmp_CFLAGS="$tmp_CFLAGS -ftree-vrp" fi + dnl Only gcc 4.4 or later + if test "$compiler_num" -ge "404"; then + CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [logical-op]) + fi + dnl Only gcc 4.5 or later if test "$compiler_num" -ge "405"; then CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [jump-misses-init])