romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-14 22:11:45 +03:00
Code Issues Projects Releases Packages Wiki Activity

http_aws_sigv4: return error on too many query components

Browse source 
Instead of just silently continuing.

Closes #17421
This commit is contained in:
Daniel Stenberg 2025-05-23 08:40:46 +02:00
parent 4331e7087b
commit 6ad9230c2d
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 8 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

18
lib/http_aws_sigv4.c
View file

@ -1025,7 +1025,7 @@ static CURLcode split_to_dyn_array(const char *source,
{
CURLcode result = CURLE_OK;
size_t len = strlen(source);
size_t pos = 0; /* Position in result buffer */
size_t pos; /* Position in result buffer */
size_t start = 0; /* Start of current segment */
size_t segment_length = 0;
size_t index = 0;
@ -1039,12 +1039,13 @@ static CURLcode split_to_dyn_array(const char *source,
curlx_dyn_init(&db[index], segment_length + 1);
result = curlx_dyn_addn(&db[index], &source[start],
segment_length);
if(result) {
if(result)
goto fail;
}
segment_length = 0;
index++;
if(++num_splits == MAX_QUERY_COMPONENTS) {
result = CURLE_TOO_LARGE;
goto fail;
}
}
@ -1057,13 +1058,10 @@ static CURLcode split_to_dyn_array(const char *source,
if(segment_length) {
curlx_dyn_init(&db[index], segment_length + 1);
result = curlx_dyn_addn(&db[index], &source[start],
segment_length);
if(result) {
goto fail;
}
if(++num_splits == MAX_QUERY_COMPONENTS) {
goto fail;
result = curlx_dyn_addn(&db[index], &source[start], segment_length);
if(!result) {
if(++num_splits == MAX_QUERY_COMPONENTS)
result = CURLE_TOO_LARGE;
}
}
fail: