romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-05-22 02:36:24 +03:00
Code Issues Projects Releases Packages Wiki Activity

runner.pm: apply minor correctness fix

Browse source 
"Lines 244-245 overwrite global variables `$runnerr` and `$runnerw` that
were already assigned in the child process (lines 205-206). In the
parent process context, these assignments appear incorrect and could
cause issues if `runner_init` is called multiple times. The parent
should only store references in the controller hashes."

It could never cause an actual issue, but clarifies the intent of the
code.

Spotted and fixed by GitHub Code Quality

Cherry-picked from #21646

Closes #21672
This commit is contained in:
Viktor Szakats 2026-05-16 18:58:47 +02:00
parent b3f76b21c9
commit 68e0b13209
No known key found for this signature in database
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/runner.pm
View file

@ -241,8 +241,10 @@ sub runner_init {
}
$controllerw{$thisrunnerid} = $thiscontrollerw;
$runnerr = $thisrunnerr;
$runnerw = $thisrunnerw;
if(!$multiprocess) {
$runnerr = $thisrunnerr;
$runnerw = $thisrunnerw;
}
$controllerr{$thisrunnerid} = $thiscontrollerr;
return $thisrunnerid;