romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-27 10:17:22 +03:00
Code Issues Projects Releases Packages Wiki Activity

os400: document threads handling in code.

Browse source 
This is to clarify threads unavaibility check and handling for security
bug busters unaware of OS400 specificities.

Fixes #18967
Closes #19009
This commit is contained in:
Patrick Monnerat 2025-10-10 15:55:50 +02:00 • committed by Daniel Stenberg
parent 05fbe85e62
commit 67c75b6712
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 19 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

22
packages/OS400/os400sys.c
View file

@ -158,6 +158,11 @@ get_buffer(struct buffer_t *buf, long size)
}
/*
* Get buffer address for the given local key.
* This is always called though `Curl_thread_buffer' and when threads are
* NOT made available by the os, so no mutex lock/unlock occurs.
*/
static char *
buffer_unthreaded(localkey_t key, long size)
{
@ -165,6 +170,12 @@ buffer_unthreaded(localkey_t key, long size)
}
/*
* Get buffer address for the given local key, taking care of
* concurrent threads.
* This is always called though `Curl_thread_buffer' and when threads are
* made available by the os.
*/
static char *
buffer_threaded(localkey_t key, long size)
{
@ -208,16 +219,21 @@ buffer_undef(localkey_t key, long size)
/* Determine if we can use pthread-specific data. */
if(Curl_thread_buffer == buffer_undef) { /* If unchanged during lock. */
if(!pthread_key_create(&thdkey, thdbufdestroy))
/* OS400 interactive jobs do not support threads: check here. */
if(!pthread_key_create(&thdkey, thdbufdestroy)) {
/* Threads are supported: use the thread-aware buffer procedure. */
Curl_thread_buffer = buffer_threaded;
}
else {
/* No multi-threading available: allocate storage for single-thread
* buffer headers. */
locbufs = calloc((size_t) LK_LAST, sizeof(*locbufs));
if(!locbufs) {
pthread_mutex_unlock(&mutex);
pthread_mutex_unlock(&mutex); /* For symetry: will probably fail. */
return (char *) NULL;
}
else
Curl_thread_buffer = buffer_unthreaded;
Curl_thread_buffer = buffer_unthreaded; /* Use unthreaded version. */
}
atexit(terminate);