romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-24 17:23:33 +03:00
Code Issues Projects Releases Packages Wiki Activity

clang-tidy: enable readability-math-missing-parentheses, adjust code

Browse source 
No functional changes.

Also:
- md4, md5: drop redundant parentheses from macro values.

Closes #20691
This commit is contained in:
Viktor Szakats 2026-02-23 00:59:57 +01:00
parent 29bca12978
commit 65262be0ab
No known key found for this signature in database
40 changed files with 85 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/tool_cb_prg.c
View file

@ -78,13 +78,13 @@ static void fly(struct ProgressData *bar, bool moved)
memcpy(&buf[bar->bar + 1], "-=O=-", 5);
pos = sinus[bar->tick % 200] / (1000000 / check) + 1;
pos = (sinus[bar->tick % 200] / (1000000 / check)) + 1;
buf[pos] = '#';
pos = sinus[(bar->tick + 5) % 200] / (1000000 / check) + 1;
pos = (sinus[(bar->tick + 5) % 200] / (1000000 / check)) + 1;
buf[pos] = '#';
pos = sinus[(bar->tick + 10) % 200] / (1000000 / check) + 1;
pos = (sinus[(bar->tick + 10) % 200] / (1000000 / check)) + 1;
buf[pos] = '#';
pos = sinus[(bar->tick + 15) % 200] / (1000000 / check) + 1;
pos = (sinus[(bar->tick + 15) % 200] / (1000000 / check)) + 1;
buf[pos] = '#';
fputs(buf, bar->out);

2
src/tool_getparam.c
View file

@ -618,7 +618,7 @@ UNITTEST ParameterError GetSizeParameter(const char *arg, curl_off_t *out)
if(value > ((CURL_OFF_T_MAX - add) / mul))
return PARAM_NUMBER_TOO_LARGE;
*out = value * mul + add;
*out = (value * mul) + add;
return PARAM_OK;
}

2
src/tool_operate.c
View file

@ -1788,7 +1788,7 @@ static CURLcode check_finished(struct parastate *s)
if(retry) {
ended->added = FALSE; /* add it again */
/* we delay retries in full integer seconds only */
ended->startat = delay ? time(NULL) + delay / 1000 : 0;
ended->startat = delay ? time(NULL) + (delay / 1000) : 0;
}
else {
/* result receives this transfer's error unless the transfer was

2
src/tool_paramhlp.c
View file

@ -326,7 +326,7 @@ ParameterError secs2ms(long *valp, const char *str)
ms = ((long)fracs * 100) / digs[len - 1];
}
*valp = (long)secs * 1000 + ms;
*valp = ((long)secs * 1000) + ms;
return PARAM_OK;
}

4
src/tool_setopt.c
View file

@ -184,7 +184,7 @@ static char *c_escape(const char *str, curl_off_t len)
CURLcode result;
struct dynbuf escaped;
curlx_dyn_init(&escaped, 4 * MAX_STRING_LENGTH_OUTPUT + 3);
curlx_dyn_init(&escaped, (4 * MAX_STRING_LENGTH_OUTPUT) + 3);
if(len == ZERO_TERMINATED)
len = strlen(str);
@ -211,7 +211,7 @@ static char *c_escape(const char *str, curl_off_t len)
if(!result) {
if(p && *p)
result = curlx_dyn_addn(&escaped, to + 2 * (p - from), 2);
result = curlx_dyn_addn(&escaped, to + (2 * (p - from)), 2);
else {
result = curlx_dyn_addf(&escaped,
/* Octal escape to avoid >2 digit hex. */

8
src/tool_urlglob.c
View file

@ -272,8 +272,8 @@ static CURLcode glob_range(struct URLGlob *glob, const char **patternp,
pat->c.ascii.letter = pat->c.ascii.min = min_c;
pat->c.ascii.max = max_c;
if(multiply(amount, ((pat->c.ascii.max - pat->c.ascii.min) /
pat->c.ascii.step + 1)))
if(multiply(amount, (((pat->c.ascii.max - pat->c.ascii.min) /
pat->c.ascii.step) + 1)))
return globerror(glob, "range overflow", *posp, CURLE_URL_MALFORMAT);
}
else if(ISDIGIT(*pattern)) {
@ -328,8 +328,8 @@ static CURLcode glob_range(struct URLGlob *glob, const char **patternp,
pat->c.num.max = max_n;
pat->c.num.step = step_n;
if(multiply(amount, ((pat->c.num.max - pat->c.num.min) /
pat->c.num.step + 1)))
if(multiply(amount, (((pat->c.num.max - pat->c.num.min) /
pat->c.num.step) + 1)))
return globerror(glob, "range overflow", *posp, CURLE_URL_MALFORMAT);
}
else