From 5d6dc816785358f505ba6922ceb507b4521c5421 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Thu, 20 Aug 2026 00:33:42 +0200 Subject: [PATCH] GHA/checksrc: preprocess workflows to lint more shell code `zizmor` keeps being confused by non-"well-known" shell designators `msys2 {0}`, `\bash.exe '{0}'`, `cpa.sh {0}`, while `actionlint` silently skips checking such shell code. Though it's all POSIX/bash. Replace the unrecognized shell designators with `bash` before running the linters, to remove these blind spots. zizmor pedantic persona: Before: `No findings to report. Good job! (1 ignored, 61 suppressed)` After: `No findings to report. Good job! (1 ignored)` zizmor auditor persona: Before: `No findings to report. Good job! (62 ignored)` After: `No findings to report. Good job! (1 ignored)` Closes #22626 --- .github/workflows/checksrc.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/checksrc.yml b/.github/workflows/checksrc.yml index f6a2ec84e5..7efc740dc0 100644 --- a/.github/workflows/checksrc.yml +++ b/.github/workflows/checksrc.yml @@ -178,6 +178,10 @@ jobs: with: persist-credentials: false + - name: 'zizmor/actionlint (prepare)' + # Replace custom bash-like shell designators with the standard one to make linters process them + run: sed -i.bak -E 's/shell\x3a .+ zizmor\x3a ignore.+$/shell\x3a bash/g' .github/workflows/*.yml + - name: 'zizmor GHA' env: GH_TOKEN: '${{ secrets.GITHUB_TOKEN }}'