romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-08 09:02:56 +03:00
Code Issues Projects Releases Packages Wiki Activity

urlapi: when URL encoding the fragment, pass in the right length

Browse source 
A benign bug because it would only add an extra null terminator.

Made lib1560 get a test that runs this code.

Closes #12250
This commit is contained in:
Daniel Stenberg 2023-11-02 13:43:54 +01:00
parent bbdbd4b025
commit 5c846a12a3
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/urlapi.c
View file

@ -1224,7 +1224,7 @@ static CURLUcode parseurl(const char *url, CURLU *u, unsigned int flags)
if(flags & CURLU_URLENCODE) {
struct dynbuf enc;
Curl_dyn_init(&enc, CURL_MAX_INPUT_LENGTH);
if(urlencode_str(&enc, fragment + 1, fraglen, TRUE, FALSE)) {
if(urlencode_str(&enc, fragment + 1, fraglen - 1, TRUE, FALSE)) {
result = CURLUE_OUT_OF_MEMORY;
goto fail;
}