From 5687d211c48b38facb9e77c59b233dc25dadb330 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Mon, 15 Jun 2026 17:04:44 +0200 Subject: [PATCH] servers: fix off-by-3 OOB write for large `loghex()` inputs Spotted by GitHub Code Quality Closes #22031 --- tests/server/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/server/util.c b/tests/server/util.c index 7a227bf0a3..77aec5aaaf 100644 --- a/tests/server/util.c +++ b/tests/server/util.c @@ -42,7 +42,7 @@ void loghex(const unsigned char *buffer, ssize_t len) ssize_t width = 0; int left = sizeof(data); - for(i = 0; i < len && (left >= 0); i++) { + for(i = 0; i < len && (left > 2); i++) { snprintf(optr, left, "%02x", ptr[i]); width += 2; optr += 2;