From 56739855f3354f4f385c24259828adfe829bbf50 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Thu, 12 Mar 2026 00:25:48 +0100 Subject: [PATCH] examples: drop warning silencers no longer hit Also: - scope clang `-Wcast-function-type-strict` silencing, add missed `pop`. Follow-up to d06b49d8b2d42d477f7e78596035832727d6d5c9 #18260 Closes #20896 --- docs/examples/cacertinmem.c | 16 +++++++--------- docs/examples/usercertinmem.c | 4 ---- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/docs/examples/cacertinmem.c b/docs/examples/cacertinmem.c index cf11785db5..144930902e 100644 --- a/docs/examples/cacertinmem.c +++ b/docs/examples/cacertinmem.c @@ -34,15 +34,6 @@ #include -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic ignored "-Woverlength-strings" -#endif -/* Silence warning when calling sk_X509_INFO_pop_free() */ -#if defined(__clang__) && __clang_major__ >= 16 -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wcast-function-type-strict" -#endif - #if defined(OPENSSL_IS_BORINGSSL) || defined(OPENSSL_IS_AWSLC) typedef size_t ossl_valsize_t; #else @@ -116,7 +107,14 @@ static CURLcode sslctx_function(CURL *curl, void *sslctx, void *pointer) } } +#if defined(__clang__) && __clang_major__ >= 16 +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wcast-function-type-strict" +#endif sk_X509_INFO_pop_free(inf, X509_INFO_free); +#if defined(__clang__) && __clang_major__ >= 16 +#pragma clang diagnostic pop +#endif result = CURLE_OK; diff --git a/docs/examples/usercertinmem.c b/docs/examples/usercertinmem.c index efbb3c2d2b..e32c5e667c 100644 --- a/docs/examples/usercertinmem.c +++ b/docs/examples/usercertinmem.c @@ -40,10 +40,6 @@ #include -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic ignored "-Woverlength-strings" -#endif - static size_t write_cb(void *ptr, size_t size, size_t nmemb, void *stream) { fwrite(ptr, size, nmemb, (FILE *)stream);